net/socket/tcp_client_socket_unittest.cc - Issue 8771030: base::Bind: Convert ServerSocket::Accept.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/tcp_client_socket_unittest.cc

Issue 8771030: base::Bind: Convert ServerSocket::Accept. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Test logic fix. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/tcp_client_socket_unittest.cc

diff --git a/net/socket/tcp_client_socket_unittest.cc b/net/socket/tcp_client_socket_unittest.cc

index 4abce1f1786428d62ec78bf8ded06842d41eedb9..50a319bd456e5b84813a654c16b2b56ce691dab0 100644

--- a/net/socket/tcp_client_socket_unittest.cc

+++ b/net/socket/tcp_client_socket_unittest.cc

@@ -41,9 +41,9 @@ TEST(TCPClientSocketTest, BindLoopbackToLoopback) {

TestOldCompletionCallback connect_callback;

EXPECT_EQ(ERR_IO_PENDING, socket.Connect(&connect_callback));

- TestOldCompletionCallback accept_callback;

+ TestCompletionCallback accept_callback;

scoped_ptr<StreamSocket> accepted_socket;

- int result = server.Accept(&accepted_socket, &accept_callback);

+ int result = server.Accept(&accepted_socket, accept_callback.callback());

if (result == ERR_IO_PENDING)

result = accept_callback.WaitForResult();

ASSERT_EQ(OK, result);

« no previous file with comments | « net/socket/server_socket.h ('k') | net/socket/tcp_server_socket_libevent.h » ('j') | no next file with comments »