Remove InfoBarDelegate::InfoBarClosed(), delete InfoBars directly.

Remove InfoBarDelegate::InfoBarClosed(), delete InfoBars directly.

Later I'd like to add a virtual InfoBarDelegate::InfoBarClosed() which subclasses can override
to receive an event when the infobar is hidden.

BUG=NONE
TEST=NONE

[jochen (gone - plz use gerrit), 2011-11-28 08:36:23]

http://codereview.chromium.org/8698016/diff/1/chrome/browser/geolocation/chro...
File
chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc
(right):

http://codereview.chromium.org/8698016/diff/1/chrome/browser/geolocation/chro...
chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc:234:
delete infobar_0;
since the infobar owns the delegate, shouldn't the infobar delete it as well?

http://codereview.chromium.org/8698016/diff/1/chrome/browser/infobars/infobar.cc
File chrome/browser/infobars/infobar.cc (right):

http://codereview.chromium.org/8698016/diff/1/chrome/browser/infobars/infobar...
chrome/browser/infobars/infobar.cc:57: InfoBar::~InfoBar() {
I wonder whether we should delete the delegate here as well, to be on the safe
side.

[marja, 2011-11-28 09:40:30]

Thanks for comments!

http://codereview.chromium.org/8698016/diff/1/chrome/browser/geolocation/chro...
File
chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc
(right):

http://codereview.chromium.org/8698016/diff/1/chrome/browser/geolocation/chro...
chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc:234:
delete infobar_0;
On 2011/11/28 08:36:23, jochen wrote:
> since the infobar owns the delegate, shouldn't the infobar delete it as well?

There is no InfoBar created in this test.

http://codereview.chromium.org/8698016/diff/1/chrome/browser/infobars/infobar.cc
File chrome/browser/infobars/infobar.cc (right):

http://codereview.chromium.org/8698016/diff/1/chrome/browser/infobars/infobar...
chrome/browser/infobars/infobar.cc:57: InfoBar::~InfoBar() {
On 2011/11/28 08:36:24, jochen wrote:
> I wonder whether we should delete the delegate here as well, to be on the safe
> side.

Done. (I made delegate_ a scoped_ptr.)

[marja, 2011-11-28 15:50:36]

http://codereview.chromium.org/8698016/diff/1/chrome/browser/infobars/infobar.cc
File chrome/browser/infobars/infobar.cc (right):

http://codereview.chromium.org/8698016/diff/1/chrome/browser/infobars/infobar...
chrome/browser/infobars/infobar.cc:57: InfoBar::~InfoBar() {
On 2011/11/28 09:40:30, marja wrote:
> On 2011/11/28 08:36:24, jochen wrote:
> > I wonder whether we should delete the delegate here as well, to be on the
safe
> > side.
> 
> Done. (I made delegate_ a scoped_ptr.)

Ouch, this was the wrong thing to do. InfoBarContainer accesses the
InfoBarDelegate after InfoBar has been destroyed. I cancelled that change. The
ownership of InfoBarDelegate is not very clear; I tried not to change it in this
CL but only replace this InfoBarClosed function with direct deletion (whoever is
doing the deleting). Is that ok?

[jochen (gone - plz use gerrit), 2011-11-28 15:51:59]

On 2011/11/28 15:50:36, marja wrote:
>
http://codereview.chromium.org/8698016/diff/1/chrome/browser/infobars/infobar.cc
> File chrome/browser/infobars/infobar.cc (right):
> 
>
http://codereview.chromium.org/8698016/diff/1/chrome/browser/infobars/infobar...
> chrome/browser/infobars/infobar.cc:57: InfoBar::~InfoBar() {
> On 2011/11/28 09:40:30, marja wrote:
> > On 2011/11/28 08:36:24, jochen wrote:
> > > I wonder whether we should delete the delegate here as well, to be on the
> safe
> > > side.
> > 
> > Done. (I made delegate_ a scoped_ptr.)
> 
> Ouch, this was the wrong thing to do. InfoBarContainer accesses the
> InfoBarDelegate after InfoBar has been destroyed. I cancelled that change. The
> ownership of InfoBarDelegate is not very clear; I tried not to change it in
this
> CL but only replace this InfoBarClosed function with direct deletion (whoever
is
> doing the deleting). Is that ok?

ok :-/