chrome/browser/infobars/infobar_tab_helper.cc - Issue 8698016: Remove InfoBarDelegate::InfoBarClosed(), delete InfoBars directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/infobars/infobar_tab_helper.cc

Issue 8698016: Remove InfoBarDelegate::InfoBarClosed(), delete InfoBars directly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Cancelling changes. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/infobars/infobar_tab_helper.cc

diff --git a/chrome/browser/infobars/infobar_tab_helper.cc b/chrome/browser/infobars/infobar_tab_helper.cc

index 000bfb45a9e26d47a89fc0fc923007a3c59f14e2..58f8223f8f1e3b944b59729e2f7bdf58e29847fa 100644

--- a/chrome/browser/infobars/infobar_tab_helper.cc

+++ b/chrome/browser/infobars/infobar_tab_helper.cc

@@ -30,13 +30,13 @@ InfoBarTabHelper::~InfoBarTabHelper() {

void InfoBarTabHelper::AddInfoBar(InfoBarDelegate* delegate) {

if (!infobars_enabled_) {

- delegate->InfoBarClosed();

+ delete delegate;

return;

}

for (size_t i = 0; i < infobars_.size(); ++i) {

if (GetInfoBarDelegateAt(i)->EqualsDelegate(delegate)) {

- delegate->InfoBarClosed();

+ delete delegate;

return;

}