Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5339)

Unified Diff: chrome/browser/download/download_request_infobar_delegate_unittest.cc

Issue 8698016: Remove InfoBarDelegate::InfoBarClosed(), delete InfoBars directly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cancelling changes. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_request_infobar_delegate_unittest.cc
diff --git a/chrome/browser/download/download_request_infobar_delegate_unittest.cc b/chrome/browser/download/download_request_infobar_delegate_unittest.cc
index fdaab1add50e172f286d69a3017fe54e5c959827..219ed09e74ccf1658085417794943c9272202701 100644
--- a/chrome/browser/download/download_request_infobar_delegate_unittest.cc
+++ b/chrome/browser/download/download_request_infobar_delegate_unittest.cc
@@ -22,12 +22,7 @@ class MockTabDownloadState : public DownloadRequestLimiter::TabDownloadState {
return infobar_->AsConfirmInfoBarDelegate();
}
void close_infobar() {
- // TODO(pkasting): Right now InfoBarDelegates delete themselves via
- // InfoBarClosed(); once InfoBars own their delegates, this can become a
- // simple reset() call and ~MockTabDownloadState() will no longer need to
- // call it.
- if (infobar_ != NULL)
- infobar_.release()->InfoBarClosed();
+ infobar_.reset(NULL);
}
bool responded() const { return responded_; }
bool accepted() const { return accepted_; }
« no previous file with comments | « no previous file | chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698