Remove InfoBarDelegate::InfoBarClosed(), delete InfoBars directly.

chrome/browser/infobars/infobar.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/infobars/infobar.h"
 
 #include <cmath>
 
 #include "build/build_config.h"
 #include "base/logging.h"
@@ skipping 36 matching lines @@
       arrow_height_(0),
       arrow_target_height_(kDefaultArrowTargetHeight),
       arrow_half_width_(0),
       bar_height_(0),
       bar_target_height_(kDefaultBarTargetHeight) {
   DCHECK(owner_ != NULL);
   DCHECK(delegate_ != NULL);
   animation_.SetTweenType(ui::Tween::LINEAR);
 }
 
 InfoBar::~InfoBar() {

[jochen (gone - plz use gerrit), 2011/11/28 08:36:24]

I wonder whether we should delete the delegate here as well, to be on the safe
side.

[marja, 2011/11/28 09:40:30]

Done. (I made delegate_ a scoped_ptr.)

[marja, 2011/11/28 15:50:36]

Ouch, this was the wrong thing to do. InfoBarContainer accesses the
InfoBarDelegate after InfoBar has been destroyed. I cancelled that change. The
ownership of InfoBarDelegate is not very clear; I tried not to change it in this
CL but only replace this InfoBarClosed function with direct deletion (whoever is
doing the deleting). Is that ok?

 }
 
 void InfoBar::Show(bool animate) {
   PlatformSpecificShow(animate);
   if (animate) {
     animation_.Show();
   } else {
     animation_.Reset(1.0);
     RecalculateHeights(true);
   }
@@ skipping 108 matching lines @@
     PlatformSpecificOnHeightsRecalculated();
 
   if (container_ && (heights_differ || force_notify))
     container_->OnInfoBarStateChanged(animation_.is_animating());
 }
 
 void InfoBar::MaybeDelete() {
   if (!owner_ && delegate_ && (animation_.GetCurrentValue() == 0.0)) {
     if (container_)
       container_->RemoveInfoBar(this);
-    delegate_->InfoBarClosed();
+    delete delegate_;
     delegate_ = NULL;
   }
 }
 
 #endif  // TOOLKIT_VIEWS || TOOLKIT_GTK