Create a field test for sync sign in promo strings.

chrome/browser/ui/webui/sync_promo_ui.cc

Index: chrome/browser/ui/webui/sync_promo_ui.cc
===================================================================
--- chrome/browser/ui/webui/sync_promo_ui.cc	(revision 111699)
+++ chrome/browser/ui/webui/sync_promo_ui.cc	(working copy)
@@ -32,7 +32,7 @@
 const char kStringsJsFile[] = "strings.js";
 const char kSyncPromoJsFile[]  = "sync_promo.js";
 
-const char kSyncPromoQueryKeyShowTitle[]  = "show_title";
+const char kSyncPromoQueryKeyLaunchPage[] = "launch_page";

[sail, 2011/11/28 16:34:25]

same, is launch page?

[SteveT, 2011/11/28 20:07:32]

Done.

 const char kSyncPromoQueryKeyNextPage[]  = "next_page";
 
 // The maximum number of times we want to show the sync promo at startup.
@@ -214,7 +214,7 @@
 // static
 GURL SyncPromoUI::GetSyncPromoURL(const GURL& next_page, bool show_title) {
   std::stringstream stream;
-  stream << chrome::kChromeUISyncPromoURL << "?" << kSyncPromoQueryKeyShowTitle
+  stream << chrome::kChromeUISyncPromoURL << "?" << kSyncPromoQueryKeyLaunchPage
          << "=" << (show_title ? "true" : "false");
 
   if (!next_page.spec().empty()) {
@@ -229,9 +229,11 @@
 }
 
 // static
-bool SyncPromoUI::GetShowTitleForSyncPromoURL(const GURL& url) {
+bool SyncPromoUI::GetLaunchPageForSyncPromoURL(const GURL& url) {
   std::string value;
-  if (GetValueForKeyInQuery(url, kSyncPromoQueryKeyShowTitle, &value))
+  // Show the title if the promo is currently the Chrome launch page (and not
+  // the page accessed through the NTP).
+  if (GetValueForKeyInQuery(url, kSyncPromoQueryKeyLaunchPage, &value))
     return value == "true";
   return false;
 }