Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1927)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/sync_promo_ui.h

Issue 8689006: Create a field test for sync sign in promo strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Init Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/webui/sync_promo_handler.cc ('K') | « chrome/browser/ui/webui/sync_promo_trial.cc ('k') | chrome/browser/ui/webui/sync_promo_ui.cc » ('j') | chrome/browser/ui/webui/sync_promo_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/sync_promo_ui.h
===================================================================
--- chrome/browser/ui/webui/sync_promo_ui.h (revision 111699)
+++ chrome/browser/ui/webui/sync_promo_ui.h (working copy)
@@ -45,8 +45,8 @@
// If |show_title| is true then the promo title is made visible.
static GURL GetSyncPromoURL(const GURL& next_page, bool show_title);
- // Gets the show title value from the query portion of the sync promo URL.
- static bool GetShowTitleForSyncPromoURL(const GURL& url);
+ // Gets the launch page value from the query portion of the sync promo URL.
sail 2011/11/28 16:34:25 "the launch page value" suggests that the return v
SteveT 2011/11/28 20:07:32 Yeah that's better. Done.
+ static bool GetLaunchPageForSyncPromoURL(const GURL& url);
sail 2011/11/28 16:34:25 Maybe GetIsLaunchPageForSyncPromoURL() instead?
SteveT 2011/11/28 20:07:32 Done.
// Gets the next page URL from the query portion of the sync promo URL.
static GURL GetNextPageURLForSyncPromoURL(const GURL& url);
« chrome/browser/ui/webui/sync_promo_handler.cc ('K') | « chrome/browser/ui/webui/sync_promo_trial.cc ('k') | chrome/browser/ui/webui/sync_promo_ui.cc » ('j') | chrome/browser/ui/webui/sync_promo_ui.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698