Create a field test for sync sign in promo strings.

chrome/browser/ui/webui/sync_promo_ui.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/sync_promo_ui.h"
 
 #include "base/command_line.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/first_run/first_run.h"
@@ skipping 14 matching lines @@
 #include "grit/browser_resources.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace {
 
 const char kStringsJsFile[] = "strings.js";
 const char kSyncPromoJsFile[]  = "sync_promo.js";
 
-const char kSyncPromoQueryKeyShowTitle[]  = "show_title";
+const char kSyncPromoQueryKeyLaunchPage[] = "launch_page";

[sail, 2011/11/28 16:34:25]

same, is launch page?

[SteveT, 2011/11/28 20:07:32]

Done.

 const char kSyncPromoQueryKeyNextPage[]  = "next_page";
 
 // The maximum number of times we want to show the sync promo at startup.
 const int kSyncPromoShowAtStartupMaximum = 10;
 
 // Checks we want to show the sync promo for the given brand.
 bool AllowPromoAtStartupForCurrentBrand() {
   std::string brand;
   google_util::GetBrand(&brand);
 
@@ skipping 161 matching lines @@
   return profile->GetPrefs()->GetBoolean(prefs::kSyncPromoUserSkipped);
 }
 
 void SyncPromoUI::SetUserSkippedSyncPromo(Profile* profile) {
   profile->GetPrefs()->SetBoolean(prefs::kSyncPromoUserSkipped, true);
 }
 
 // static
 GURL SyncPromoUI::GetSyncPromoURL(const GURL& next_page, bool show_title) {
   std::stringstream stream;
-  stream << chrome::kChromeUISyncPromoURL << "?" << kSyncPromoQueryKeyShowTitle
+  stream << chrome::kChromeUISyncPromoURL << "?" << kSyncPromoQueryKeyLaunchPage
          << "=" << (show_title ? "true" : "false");
 
   if (!next_page.spec().empty()) {
     url_canon::RawCanonOutputT<char> output;
     url_util::EncodeURIComponent(
         next_page.spec().c_str(), next_page.spec().length(), &output);
     std::string escaped_spec(output.data(), output.length());
     stream << "&" << kSyncPromoQueryKeyNextPage << "=" << escaped_spec;
   }
 
   return GURL(stream.str());
 }
 
 // static
-bool SyncPromoUI::GetShowTitleForSyncPromoURL(const GURL& url) {
+bool SyncPromoUI::GetLaunchPageForSyncPromoURL(const GURL& url) {
   std::string value;
-  if (GetValueForKeyInQuery(url, kSyncPromoQueryKeyShowTitle, &value))
+  // Show the title if the promo is currently the Chrome launch page (and not
+  // the page accessed through the NTP).
+  if (GetValueForKeyInQuery(url, kSyncPromoQueryKeyLaunchPage, &value))
     return value == "true";
   return false;
 }
 
 // static
 GURL SyncPromoUI::GetNextPageURLForSyncPromoURL(const GURL& url) {
   std::string value;
   if (GetValueForKeyInQuery(url, kSyncPromoQueryKeyNextPage, &value)) {
     url_canon::RawCanonOutputT<char16> output;
     url_util::DecodeURLEscapeSequences(value.c_str(), value.length(), &output);
     std::string url;
     UTF16ToUTF8(output.data(), output.length(), &url);
     return GURL(url);
   }
   return GURL();
 }
 
 // static
 bool SyncPromoUI::UserHasSeenSyncPromoAtStartup(Profile* profile) {
   return profile->GetPrefs()->GetInteger(prefs::kSyncPromoStartupCount) > 0;
 }