Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: chrome/browser/ui/webui/sync_setup_handler.cc

Issue 8689006: Create a field test for sync sign in promo strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Init Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/sync_setup_handler.cc
===================================================================
--- chrome/browser/ui/webui/sync_setup_handler.cc (revision 111699)
+++ chrome/browser/ui/webui/sync_setup_handler.cc (working copy)
@@ -384,6 +384,10 @@
{ "aspWarningText", IDS_SYNC_ASP_PASSWORD_WARNING_TEXT },
{ "promoPageTitle", IDS_SYNC_PROMO_TAB_TITLE},
{ "promoMessageBody", IDS_SYNC_PROMO_MESSAGE_BODY},
+ { "promoMessageBodyA", IDS_SYNC_PROMO_MESSAGE_BODY_A},
sail 2011/11/28 16:34:25 instead of having multiple strings here and then d
SteveT 2011/11/28 20:07:32 So I addressed this roughly in the way you suggest
+ { "promoMessageBodyB", IDS_SYNC_PROMO_MESSAGE_BODY_B},
+ { "promoMessageBodyC", IDS_SYNC_PROMO_MESSAGE_BODY_C},
+ { "promoMessageBodyD", IDS_SYNC_PROMO_MESSAGE_BODY_D},
{ "promoSkipButton", IDS_SYNC_PROMO_SKIP_BUTTON},
{ "promoAdvanced", IDS_SYNC_PROMO_ADVANCED},
{ "promoLearnMoreShow", IDS_SYNC_PROMO_LEARN_MORE_SHOW},

Powered by Google App Engine
This is Rietveld 408576698