Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8687002: Cleanup: Convert ASCIIToUTF16("") to string16(). (Closed)

Created:
9 years ago by James Hawkins
Modified:
9 years ago
Reviewers:
Greg Billock
CC:
chromium-reviews, GeorgeY, cbentzel+watch_chromium.org, rdsmith+dwatch_chromium.org, yusukes+watch_chromium.org, tfarina, Paweł Hajdan Jr., kkania, penghuang+watch_chromium.org, robertshield, dyu1, brettw-cc_chromium.org, darin-cc_chromium.org, James Su, Ilya Sherman, jshin+watch_chromium.org, dhollowa
Visibility:
Public.

Description

Cleanup: Convert ASCIIToUTF16("") to string16(). Inspired by r111713. BUG=none TEST=none R=gbillock@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111768

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -80 lines) Patch
M base/i18n/string_search_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M base/string_piece_unittest.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M base/string_util_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/autofill/address_field_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/autofill/form_field_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/autofill/phone_number_i18n_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/autofill/phone_number_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_tab_helper_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/download/download_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/importer/firefox_importer_unittest.cc View 7 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/importer/safari_importer_unittest.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/page_info_model.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/flash_ui.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/webdata/web_database_migration_unittest.cc View 11 chunks +18 lines, -18 lines 0 comments Download
M net/base/cert_database_nss_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/gfx/font_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/textfield/textfield_views_model_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/plugin_group_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_list_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
James Hawkins
9 years ago (2011-11-28 18:07:56 UTC) #1
Greg Billock
9 years ago (2011-11-28 18:57:49 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698