Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: base/i18n/string_search_unittest.cc

Issue 8687002: Cleanup: Convert ASCIIToUTF16("") to string16(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | base/string_piece_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/i18n/rtl.h" 7 #include "base/i18n/rtl.h"
8 #include "base/i18n/string_search.h" 8 #include "base/i18n/string_search.h"
9 #include "base/string16.h"
9 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
10 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
11 #include "unicode/usearch.h" 12 #include "unicode/usearch.h"
12 13
13 namespace base { 14 namespace base {
14 namespace i18n { 15 namespace i18n {
15 16
16 // Note on setting default locale for testing: The current default locale on 17 // Note on setting default locale for testing: The current default locale on
17 // the Mac trybot is en_US_POSIX, with which primary-level collation strength 18 // the Mac trybot is en_US_POSIX, with which primary-level collation strength
18 // string search is case-sensitive, when normally it should be 19 // string search is case-sensitive, when normally it should be
19 // case-insensitive. In other locales (including en_US which English speakers 20 // case-insensitive. In other locales (including en_US which English speakers
20 // in the U.S. use), this search would be case-insensitive as expected. 21 // in the U.S. use), this search would be case-insensitive as expected.
21 22
22 TEST(StringSearchTest, ASCII) { 23 TEST(StringSearchTest, ASCII) {
23 std::string default_locale(uloc_getDefault()); 24 std::string default_locale(uloc_getDefault());
24 bool locale_is_posix = (default_locale == "en_US_POSIX"); 25 bool locale_is_posix = (default_locale == "en_US_POSIX");
25 if (locale_is_posix) 26 if (locale_is_posix)
26 SetICUDefaultLocale("en_US"); 27 SetICUDefaultLocale("en_US");
27 28
28 EXPECT_TRUE(StringSearchIgnoringCaseAndAccents( 29 EXPECT_TRUE(StringSearchIgnoringCaseAndAccents(
29 ASCIIToUTF16("hello"), ASCIIToUTF16("hello world"))); 30 ASCIIToUTF16("hello"), ASCIIToUTF16("hello world")));
30 31
31 EXPECT_FALSE(StringSearchIgnoringCaseAndAccents( 32 EXPECT_FALSE(StringSearchIgnoringCaseAndAccents(
32 ASCIIToUTF16("h e l l o"), ASCIIToUTF16("h e l l o"))); 33 ASCIIToUTF16("h e l l o"), ASCIIToUTF16("h e l l o")));
33 34
34 EXPECT_TRUE(StringSearchIgnoringCaseAndAccents( 35 EXPECT_TRUE(StringSearchIgnoringCaseAndAccents(
35 ASCIIToUTF16("aabaaa"), ASCIIToUTF16("aaabaabaaa"))); 36 ASCIIToUTF16("aabaaa"), ASCIIToUTF16("aaabaabaaa")));
36 37
37 EXPECT_FALSE(StringSearchIgnoringCaseAndAccents( 38 EXPECT_FALSE(StringSearchIgnoringCaseAndAccents(
38 ASCIIToUTF16("searching within empty string"), ASCIIToUTF16(""))); 39 ASCIIToUTF16("searching within empty string"), string16()));
39 40
40 EXPECT_TRUE(StringSearchIgnoringCaseAndAccents( 41 EXPECT_TRUE(StringSearchIgnoringCaseAndAccents(
41 ASCIIToUTF16(""), ASCIIToUTF16("searching for empty string"))); 42 string16(), ASCIIToUTF16("searching for empty string")));
42 43
43 EXPECT_TRUE(StringSearchIgnoringCaseAndAccents( 44 EXPECT_TRUE(StringSearchIgnoringCaseAndAccents(
44 ASCIIToUTF16("case insensitivity"), ASCIIToUTF16("CaSe InSeNsItIvItY"))); 45 ASCIIToUTF16("case insensitivity"), ASCIIToUTF16("CaSe InSeNsItIvItY")));
45 46
46 if (locale_is_posix) 47 if (locale_is_posix)
47 SetICUDefaultLocale(default_locale.data()); 48 SetICUDefaultLocale(default_locale.data());
48 } 49 }
49 50
50 TEST(StringSearchTest, UnicodeLocaleIndependent) { 51 TEST(StringSearchTest, UnicodeLocaleIndependent) {
51 // Base characters 52 // Base characters
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 143
143 EXPECT_FALSE(StringSearchIgnoringCaseAndAccents( 144 EXPECT_FALSE(StringSearchIgnoringCaseAndAccents(
144 a_base, a_with_ring)); 145 a_base, a_with_ring));
145 146
146 SetICUDefaultLocale(default_locale); 147 SetICUDefaultLocale(default_locale);
147 } 148 }
148 149
149 } // namespace i18n 150 } // namespace i18n
150 } // namespace base 151 } // namespace base
151 152
OLDNEW
« no previous file with comments | « no previous file | base/string_piece_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698