base/string_piece_unittest.cc - Issue 8687002: Cleanup: Convert ASCIIToUTF16("") to string16().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/string_piece_unittest.cc

Issue 8687002: Cleanup: Convert ASCIIToUTF16("") to string16(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/string_piece_unittest.cc

diff --git a/base/string_piece_unittest.cc b/base/string_piece_unittest.cc

index 5339c09a3874deb9a07be364d307532433ee7266..694c43b61f5dddf1ca69406657c462f26c4028a5 100644

--- a/base/string_piece_unittest.cc

+++ b/base/string_piece_unittest.cc

@@ -4,6 +4,7 @@

#include <string>

+#include "base/string16.h"

#include "base/string_piece.h"

#include "base/utf_string_conversions.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -542,15 +543,15 @@ TEST(StringPieceTest, HeterogenousStringPieceEquals) {

}

TEST(StringPiece16Test, CheckComparisonOperators) {

- ASSERT_TRUE(StringPiece16(ASCIIToUTF16("")) ==

- StringPiece16(ASCIIToUTF16("")));

+ ASSERT_TRUE(StringPiece16(string16()) ==

+ StringPiece16(string16()));

ASSERT_TRUE(StringPiece16(ASCIIToUTF16("a")) ==

StringPiece16(ASCIIToUTF16("a")));

ASSERT_TRUE(StringPiece16(ASCIIToUTF16("aa")) ==

StringPiece16(ASCIIToUTF16("aa")));

ASSERT_FALSE(StringPiece16(ASCIIToUTF16("a")) ==

- StringPiece16(ASCIIToUTF16("")));

- ASSERT_FALSE(StringPiece16(ASCIIToUTF16("")) ==

+ StringPiece16(string16()));

+ ASSERT_FALSE(StringPiece16(string16()) ==

StringPiece16(ASCIIToUTF16("a")));

ASSERT_FALSE(StringPiece16(ASCIIToUTF16("a")) ==

StringPiece16(ASCIIToUTF16("b")));

@@ -559,15 +560,15 @@ TEST(StringPiece16Test, CheckComparisonOperators) {

ASSERT_FALSE(StringPiece16(ASCIIToUTF16("aa")) ==

StringPiece16(ASCIIToUTF16("a")));

- ASSERT_FALSE(StringPiece16(ASCIIToUTF16("")) !=

- StringPiece16(ASCIIToUTF16("")));

+ ASSERT_FALSE(StringPiece16(string16()) !=

+ StringPiece16(string16()));

ASSERT_FALSE(StringPiece16(ASCIIToUTF16("a")) !=

StringPiece16(ASCIIToUTF16("a")));

ASSERT_FALSE(StringPiece16(ASCIIToUTF16("aa")) !=

StringPiece16(ASCIIToUTF16("aa")));

ASSERT_TRUE(StringPiece16(ASCIIToUTF16("a")) !=

- StringPiece16(ASCIIToUTF16("")));

- ASSERT_TRUE(StringPiece16(ASCIIToUTF16("")) !=

+ StringPiece16(string16()));

+ ASSERT_TRUE(StringPiece16(string16()) !=

StringPiece16(ASCIIToUTF16("a")));

ASSERT_TRUE(StringPiece16(ASCIIToUTF16("a")) !=

StringPiece16(ASCIIToUTF16("b")));

« no previous file with comments | « base/i18n/string_search_unittest.cc ('k') | base/string_util_unittest.cc » ('j') | no next file with comments »