Cleanup: Convert ASCIIToUTF16("") to string16().

chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/toolbar/back_forward_menu_model.h"
 
 #include "base/path_service.h"
+#include "base/string16.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/history/history.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/browser/tab_contents/navigation_controller.h"
 #include "content/browser/tab_contents/navigation_entry.h"
@@ skipping 320 matching lines @@
   // i = 32
   LoadURLAndUpdateState("http://www.k.com/3", "K3");
   ValidateModel(back_model.get(), i++, 6);
 
   // A chapter stop is defined as the last page the user
   // browsed to within the same domain.
 
   // Check to see if the chapter stops have the right labels.
   int index = BackForwardMenuModel::kMaxHistoryItems;
   // Empty string indicates item is a separator.
-  EXPECT_EQ(ASCIIToUTF16(""), back_model->GetLabelAt(index++));
+  EXPECT_EQ(string16(), back_model->GetLabelAt(index++));
   EXPECT_EQ(ASCIIToUTF16("F3"), back_model->GetLabelAt(index++));
   EXPECT_EQ(ASCIIToUTF16("E3"), back_model->GetLabelAt(index++));
   EXPECT_EQ(ASCIIToUTF16("D3"), back_model->GetLabelAt(index++));
   EXPECT_EQ(ASCIIToUTF16("C3"), back_model->GetLabelAt(index++));
   // The menu should only show a maximum of 5 chapter stops.
   EXPECT_EQ(ASCIIToUTF16("B3"), back_model->GetLabelAt(index));
   // Empty string indicates item is a separator.
-  EXPECT_EQ(ASCIIToUTF16(""), back_model->GetLabelAt(index + 1));
+  EXPECT_EQ(string16(), back_model->GetLabelAt(index + 1));
   EXPECT_EQ(back_model->GetShowFullHistoryLabel(),
             back_model->GetLabelAt(index + 2));
 
   // If we go back two we should still see the same chapter stop at the end.
   GoBack();
   EXPECT_EQ(ASCIIToUTF16("B3"), back_model->GetLabelAt(index));
   GoBack();
   EXPECT_EQ(ASCIIToUTF16("B3"), back_model->GetLabelAt(index));
   // But if we go back again, it should change.
   GoBack();
   EXPECT_EQ(ASCIIToUTF16("A3"), back_model->GetLabelAt(index));
   GoBack();
   EXPECT_EQ(ASCIIToUTF16("A3"), back_model->GetLabelAt(index));
   GoBack();
   EXPECT_EQ(ASCIIToUTF16("A3"), back_model->GetLabelAt(index));
   GoBack();
   // It is now a separator.
-  EXPECT_EQ(ASCIIToUTF16(""), back_model->GetLabelAt(index));
+  EXPECT_EQ(string16(), back_model->GetLabelAt(index));
   // Undo our position change.
   NavigateToOffset(6);
 
   // Go back enough to make sure no chapter stops should appear.
   NavigateToOffset(-BackForwardMenuModel::kMaxHistoryItems);
   ValidateModel(forward_model.get(), BackForwardMenuModel::kMaxHistoryItems, 0);
   // Go forward (still no chapter stop)
   GoForward();
   ValidateModel(forward_model.get(),
                 BackForwardMenuModel::kMaxHistoryItems - 1, 0);
   // Go back two (one chapter stop should show up)
   GoBack();
   GoBack();
   ValidateModel(forward_model.get(),
                 BackForwardMenuModel::kMaxHistoryItems, 1);
 
   // Go to beginning.
   NavigateToIndex(0);
 
   // Check to see if the chapter stops have the right labels.
   index = BackForwardMenuModel::kMaxHistoryItems;
   // Empty string indicates item is a separator.
-  EXPECT_EQ(ASCIIToUTF16(""), forward_model->GetLabelAt(index++));
+  EXPECT_EQ(string16(), forward_model->GetLabelAt(index++));
   EXPECT_EQ(ASCIIToUTF16("E3"), forward_model->GetLabelAt(index++));
   EXPECT_EQ(ASCIIToUTF16("F3"), forward_model->GetLabelAt(index++));
   EXPECT_EQ(ASCIIToUTF16("G3"), forward_model->GetLabelAt(index++));
   EXPECT_EQ(ASCIIToUTF16("H3"), forward_model->GetLabelAt(index++));
   // The menu should only show a maximum of 5 chapter stops.
   EXPECT_EQ(ASCIIToUTF16("I3"), forward_model->GetLabelAt(index));
   // Empty string indicates item is a separator.
-  EXPECT_EQ(ASCIIToUTF16(""), forward_model->GetLabelAt(index + 1));
+  EXPECT_EQ(string16(), forward_model->GetLabelAt(index + 1));
   EXPECT_EQ(forward_model->GetShowFullHistoryLabel(),
       forward_model->GetLabelAt(index + 2));
 
   // If we advance one we should still see the same chapter stop at the end.
   GoForward();
   EXPECT_EQ(ASCIIToUTF16("I3"), forward_model->GetLabelAt(index));
   // But if we advance one again, it should change.
   GoForward();
   EXPECT_EQ(ASCIIToUTF16("J3"), forward_model->GetLabelAt(index));
   GoForward();
@@ skipping 134 matching lines @@
   // Verify we did get the expected favicon.
   EXPECT_EQ(0, memcmp(new_icon.getPixels(), valid_icon.getPixels(),
               new_icon.getSize()));
 
   // Make sure the browser deconstructor doesn't have problems.
   browser.CloseAllTabs();
   // This is required to prevent the message loop from hanging.
   profile()->DestroyHistoryService();
 }