Make malicious content download warning include the download filename

Make malicious content download warning include the download filename.

BUG=102540
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111281

[Randy Smith (Not in Mondays), 2011-11-22 16:58:08]

Could you change the descriptive text slightly?  I'd like the first line to not
be cut off, and for the description to not sound tautological.  Maybe

"Make malicious content downloads include the download filename."

(but I don't care a lot about the phrasing if it satisfies my two requirements
above)

Beyond that, LGTM.  There's some specific approval process for doing strings
changes which I'm trying to dig up--please don't land this CL until that's done.

[asanka, 2011-11-22 17:07:47]

http://codereview.chromium.org/8624008/diff/1/chrome/browser/ui/views/downloa...
File chrome/browser/ui/views/download/download_item_view.cc (right):

http://codereview.chromium.org/8624008/diff/1/chrome/browser/ui/views/downloa...
chrome/browser/ui/views/download/download_item_view.cc:1007:
IDS_PROMPT_DANGEROUS_DOWNLOAD_EXTENSION :
IDS_PROMPT_DANGEROUS_DOWNLOAD

[noelutz, 2011-11-22 17:32:05]

Addressed your comments and sent and email to the UI leads for approval.

Thanks,
noé.

http://codereview.chromium.org/8624008/diff/1/chrome/browser/ui/views/downloa...
File chrome/browser/ui/views/download/download_item_view.cc (right):

http://codereview.chromium.org/8624008/diff/1/chrome/browser/ui/views/downloa...
chrome/browser/ui/views/download/download_item_view.cc:1007:
IDS_PROMPT_DANGEROUS_DOWNLOAD_EXTENSION :
On 2011/11/22 17:07:47, asanka wrote:
> IDS_PROMPT_DANGEROUS_DOWNLOAD

Good catch. Done.

[asanka, 2011-11-22 19:12:08]

LGTM!

[commit-bot: I haz the power, 2011-11-22 21:58:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noelutz@google.com/8624008/3003

[commit-bot: I haz the power, 2011-11-22 21:58:28]

Presubmit check for 8624008-3003 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/resources/downloads.js,chrome/browser/resources/active_downloads.js

Presubmit checks took 1.8s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[noelutz, 2011-11-22 22:24:19]

+bsh for chrome/browser/resources/*.js.

thanks,
noe.

On 2011/11/22 21:58:28, I haz the power (commit-bot) wrote:
> Presubmit check for 8624008-3003 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit Messages **
> If this change requires manual test instructions to QA team, add
> TEST=[instructions].
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for:
>
chrome/browser/resources/downloads.js,chrome/browser/resources/active_downloads.js
> 
> Presubmit checks took 1.8s to calculate.
> 
> Was the presubmit check useful? Please send feedback & hate mail to
> maruel@chromium.org!

[Randy Smith (Not in Mondays), 2011-11-22 22:34:47]

Noe': Ben's the right person in terms of knowledge of those files, but I don't
think he has OWNERS authority for them.  OTOH, that OWNERS files doesn't have
set noparent, so I'm not sure why we're getting trouble in the first place :-J.

Adding jhawkins@chromium.org for rubberstamp on chrome/browser/resources files.

[benjhayden, 2011-11-22 22:41:12]

LGTM

[James Hawkins, 2011-11-22 22:41:34]

chrome/browser/resources lgtm

[commit-bot: I haz the power, 2011-11-22 22:49:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noelutz@google.com/8624008/3003

[commit-bot: I haz the power, 2011-11-23 01:54:02]

Change committed as 111281