chrome/browser/ui/gtk/download/download_item_gtk.cc - Issue 8624008: Make malicious content download warning include the download filename

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/download/download_item_gtk.cc

Issue 8624008: Make malicious content download warning include the download filename (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Address Asanka's comment. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/download/download_item_controller.mm ('k') | chrome/browser/ui/views/download/download_item_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/download/download_item_gtk.cc

diff --git a/chrome/browser/ui/gtk/download/download_item_gtk.cc b/chrome/browser/ui/gtk/download/download_item_gtk.cc

index b6f01c0bb9700b297704d60d39a4709b5e6d5b79..54d449831adee274e182b93adcbc43315ea3e97c 100644

--- a/chrome/browser/ui/gtk/download/download_item_gtk.cc

+++ b/chrome/browser/ui/gtk/download/download_item_gtk.cc

@@ -561,9 +561,10 @@ void DownloadItemGtk::UpdateDangerWarning() {

// The dangerous download label text is different for different cases.

if (get_download()->GetDangerType() == DownloadStateInfo::DANGEROUS_URL) {

+ // TODO(noelutz): handle malicious content warning.

// Safebrowsing shows the download URL leads to malicious file.

dangerous_warning =

- l10n_util::GetStringUTF16(IDS_PROMPT_UNSAFE_DOWNLOAD_URL);

+ l10n_util::GetStringUTF16(IDS_PROMPT_MALICIOUS_DOWNLOAD_URL);

} else {

// It's a dangerous file type (e.g.: an executable).

DCHECK(get_download()->GetDangerType() ==