chrome/browser/resources/active_downloads.js - Issue 8624008: Make malicious content download warning include the download filename

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/active_downloads.js

Issue 8624008: Make malicious content download warning include the download filename (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Address Asanka's comment. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/active_downloads.js

diff --git a/chrome/browser/resources/active_downloads.js b/chrome/browser/resources/active_downloads.js

index 590d6396b23c7101022a76592df3425a3239ef7f..c7ad119184a9f2f4819f5a153287d36f1f743d49 100644

--- a/chrome/browser/resources/active_downloads.js

+++ b/chrome/browser/resources/active_downloads.js

@@ -382,8 +382,10 @@ DownloadRow.prototype = {

// Handle dangerous files, extensions and dangerous urls.

var dangerText;

- if (dangerType == 'DANGEROUS_URL' || dangerType == 'DANGEROUS_CONTENT') {

+ if (dangerType == 'DANGEROUS_URL') {

dangerText = localStrings.getString('dangerousurl');

+ } else if (dangerType == 'DANGEROUS_CONTENT') {

+ dangerText = localStrings.getStringF('dangerouscontent', this.name);

} else if (dangerType == 'DANGEROUS_FILE' && this.path.match(/\.crx$/)) {

dangerText = localStrings.getString('dangerousextension');

} else {

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/resources/downloads.js » ('j') | no next file with comments »