Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1347)

Unified Diff: chrome/browser/resources/downloads.js

Issue 8624008: Make malicious content download warning include the download filename (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Address Asanka's comment. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/downloads.js
diff --git a/chrome/browser/resources/downloads.js b/chrome/browser/resources/downloads.js
index 9e78342e84281c047acf836baa28e736d08902ef..6f30cf95f807077b02b0848f74a25925cabb1daa 100644
--- a/chrome/browser/resources/downloads.js
+++ b/chrome/browser/resources/downloads.js
@@ -347,9 +347,11 @@ Download.prototype.update = function(download) {
if (this.dangerType_ == Download.DangerType.DANGEROUS_FILE) {
this.dangerDesc_.textContent = localStrings.getStringF('danger_file_desc',
this.fileName_);
- } else {
- // This is used by both DANGEROUS_URL and DANGEROUS_CONTENT.
+ } else if (this.dangerType_ == Download.DangerType.DANGEROUS_URL) {
this.dangerDesc_.textContent = localStrings.getString('danger_url_desc');
+ } else if (this.dangerType_ == Download.DangerType.DANGEROUS_CONTENT) {
+ this.dangerDesc_.textContent = localStrings.getStringF(
+ 'danger_content_desc', this.fileName_);
}
this.danger_.style.display = 'block';
this.safe_.style.display = 'none';
« no previous file with comments | « chrome/browser/resources/active_downloads.js ('k') | chrome/browser/ui/cocoa/download/download_item_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698