Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8612007: Add OVERRIDE to chrome/browser/. (Closed)

Created:
9 years, 1 month ago by Avi (use Gerrit)
Modified:
9 years, 1 month ago
Reviewers:
Nico, eroman
CC:
chromium-reviews, vrk (LEFT CHROMIUM), yoshiki+watch_chromium.org, mihaip+watch_chromium.org, dmazzoni+watch_chromium.org, native-client-reviews_googlegroups.com, Ilya Sherman, dhollowa, GeorgeY, cbentzel+watch_chromium.org, aboxhall+watch_chromium.org, Erik does not do reviews, acolwell+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, scherkus (not reviewing), ihf+watch_chromium.org, dtseng+watch_chromium.org, rdsmith+dwatch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, yuzo+watch_chromium.org, annacc+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, hclam+watch_chromium.org, hashimoto+watch_chromium.org, tfarina, davidbarr+watch_chromium.org, Aaron Boodman, eroman, dyu1, Paweł Hajdan Jr., James Su, mmenke
Visibility:
Public.

Description

Add OVERRIDE to chrome/browser/. BUG=104314 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110939

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+423 lines, -373 lines) Patch
M chrome/browser/accessibility_events.h View 12 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/builtin_provider.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/keyword_provider.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete_history_manager.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/autofill/autofill_xml_parser.h View 3 chunks +13 lines, -8 lines 0 comments Download
M chrome/browser/background/background_application_list_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_contents_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/background/background_contents_service_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_extension_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_manager_extension_api.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_storage.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/recently_used_folders_combo_model.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data_cookie_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data_remover.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chrome_benchmarking_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_plugin_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_plugin_service_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cookies_tree_model.h View 18 chunks +28 lines, -28 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/debugger/browser_list_tabcontents_provider.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/debugger/debugger_remote_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/debugger/devtools_protocol_handler.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/debugger/devtools_remote_listen_socket.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/debugger/devtools_remote_listen_socket_unittest.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/debugger/devtools_remote_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/debugger/devtools_window.h View 3 chunks +14 lines, -12 lines 2 comments Download
M chrome/browser/debugger/extension_ports_remote_service.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/debugger/inspectable_tab_proxy.h View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/diagnostics/diagnostics_test.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/download/download_file_picker.h View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/download/download_item_model.h View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/download/download_request_limiter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_throttling_resource_handler.h View 1 chunk +19 lines, -12 lines 0 comments Download
M chrome/browser/download/save_package_file_picker.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/file_select_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/chrome_access_token_store.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context.h View 1 chunk +11 lines, -9 lines 0 comments Download
M chrome/browser/google/google_url_tracker.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/history/archived_database.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_backend.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_database.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_tab_helper.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/history/in_memory_database.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/in_memory_history_backend.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/top_sites.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/icon_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/toolbar_importer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/infobars/infobar_extension_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/intents/web_intents_registry.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/intents/web_intents_registry_factory.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/intranet_redirect_detector.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/io_thread.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media/media_internals.h View 1 chunk +11 lines, -6 lines 0 comments Download
M chrome/browser/metrics/field_trial_synchronizer.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/metrics/metrics_log.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_log_serializer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/metrics_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/thread_watcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/mock_browsing_data_cookie_helper.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/mock_browsing_data_database_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/mock_keychain_mac.h View 2 chunks +41 lines, -37 lines 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.h View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.h View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/net/gaia/token_service.h View 2 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/net/gaia/token_service_unittest.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/net/http_server_properties_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/load_timing_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/net_pref_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/network_stats.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/net/passive_log_collector.h View 18 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/net/predictor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/pref_proxy_config_tracker_impl.h View 3 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/net/sdch_dictionary_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/balloon_collection_impl.h View 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/browser/notifications/balloon_host.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notifications_unittest.h View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/notifications/notification_object_proxy.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/notifications/notification_options_menu_model.h View 3 chunks +15 lines, -13 lines 0 comments Download
M chrome/browser/notifications/notification_test_util.h View 2 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/notifications/notification_ui_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
9 years, 1 month ago (2011-11-21 15:32:29 UTC) #1
Nico
lgtm a comment! http://codereview.chromium.org/8612007/diff/1/chrome/browser/debugger/devtools_window.h File chrome/browser/debugger/devtools_window.h (right): http://codereview.chromium.org/8612007/diff/1/chrome/browser/debugger/devtools_window.h#newcode64 chrome/browser/debugger/devtools_window.h:64: RenderViewHost* GetRenderViewHost(); This is not an ...
9 years, 1 month ago (2011-11-21 16:03:12 UTC) #2
Avi (use Gerrit)
http://codereview.chromium.org/8612007/diff/1/chrome/browser/debugger/devtools_window.h File chrome/browser/debugger/devtools_window.h (right): http://codereview.chromium.org/8612007/diff/1/chrome/browser/debugger/devtools_window.h#newcode64 chrome/browser/debugger/devtools_window.h:64: RenderViewHost* GetRenderViewHost(); On 2011/11/21 16:03:13, Nico wrote: > This ...
9 years, 1 month ago (2011-11-21 16:16:50 UTC) #3
eroman
9 years, 1 month ago (2011-11-21 20:51:07 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698