Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Unified Diff: chrome/browser/net/passive_log_collector.h

Issue 8612007: Add OVERRIDE to chrome/browser/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/passive_log_collector.h
diff --git a/chrome/browser/net/passive_log_collector.h b/chrome/browser/net/passive_log_collector.h
index 63e2b18c80a6053e6fd5ec74e267438ca4259f4b..7a720f313f8973a41beb5c5f3002f61da415fd87 100644
--- a/chrome/browser/net/passive_log_collector.h
+++ b/chrome/browser/net/passive_log_collector.h
@@ -93,9 +93,9 @@ class PassiveLogCollector : public ChromeNetLog::ThreadSafeObserverImpl {
virtual ~GlobalSourceTracker();
// SourceTrackerInterface implementation:
- virtual void OnAddEntry(const ChromeNetLog::Entry& entry);
- virtual void Clear();
- virtual void AppendAllEntries(ChromeNetLog::EntryList* out) const;
+ virtual void OnAddEntry(const ChromeNetLog::Entry& entry) OVERRIDE;
+ virtual void Clear() OVERRIDE;
+ virtual void AppendAllEntries(ChromeNetLog::EntryList* out) const OVERRIDE;
private:
typedef std::deque<ChromeNetLog::Entry> CircularEntryList;
@@ -119,9 +119,9 @@ class PassiveLogCollector : public ChromeNetLog::ThreadSafeObserverImpl {
virtual ~SourceTracker();
// SourceTrackerInterface implementation:
- virtual void OnAddEntry(const ChromeNetLog::Entry& entry);
- virtual void Clear();
- virtual void AppendAllEntries(ChromeNetLog::EntryList* out) const;
+ virtual void OnAddEntry(const ChromeNetLog::Entry& entry) OVERRIDE;
+ virtual void Clear() OVERRIDE;
+ virtual void AppendAllEntries(ChromeNetLog::EntryList* out) const OVERRIDE;
#ifdef UNIT_TEST
// Helper used to inspect the current state by unit-tests.
@@ -202,7 +202,7 @@ class PassiveLogCollector : public ChromeNetLog::ThreadSafeObserverImpl {
private:
virtual Action DoAddEntry(const ChromeNetLog::Entry& entry,
- SourceInfo* out_info);
+ SourceInfo* out_info) OVERRIDE;
DISALLOW_COPY_AND_ASSIGN(ConnectJobTracker);
};
@@ -216,7 +216,7 @@ class PassiveLogCollector : public ChromeNetLog::ThreadSafeObserverImpl {
private:
virtual Action DoAddEntry(const ChromeNetLog::Entry& entry,
- SourceInfo* out_info);
+ SourceInfo* out_info) OVERRIDE;
DISALLOW_COPY_AND_ASSIGN(SocketTracker);
};
@@ -231,7 +231,7 @@ class PassiveLogCollector : public ChromeNetLog::ThreadSafeObserverImpl {
private:
virtual Action DoAddEntry(const ChromeNetLog::Entry& entry,
- SourceInfo* out_info);
+ SourceInfo* out_info) OVERRIDE;
DISALLOW_COPY_AND_ASSIGN(RequestTracker);
};
@@ -247,7 +247,7 @@ class PassiveLogCollector : public ChromeNetLog::ThreadSafeObserverImpl {
private:
virtual Action DoAddEntry(const ChromeNetLog::Entry& entry,
- SourceInfo* out_info);
+ SourceInfo* out_info) OVERRIDE;
DISALLOW_COPY_AND_ASSIGN(InitProxyResolverTracker);
};
@@ -262,7 +262,7 @@ class PassiveLogCollector : public ChromeNetLog::ThreadSafeObserverImpl {
private:
virtual Action DoAddEntry(const ChromeNetLog::Entry& entry,
- SourceInfo* out_info);
+ SourceInfo* out_info) OVERRIDE;
DISALLOW_COPY_AND_ASSIGN(SpdySessionTracker);
};
@@ -277,7 +277,7 @@ class PassiveLogCollector : public ChromeNetLog::ThreadSafeObserverImpl {
private:
virtual Action DoAddEntry(const ChromeNetLog::Entry& entry,
- SourceInfo* out_info);
+ SourceInfo* out_info) OVERRIDE;
DISALLOW_COPY_AND_ASSIGN(DNSRequestTracker);
};
@@ -292,7 +292,7 @@ class PassiveLogCollector : public ChromeNetLog::ThreadSafeObserverImpl {
private:
virtual Action DoAddEntry(const ChromeNetLog::Entry& entry,
- SourceInfo* out_info);
+ SourceInfo* out_info) OVERRIDE;
DISALLOW_COPY_AND_ASSIGN(DNSJobTracker);
};
@@ -307,7 +307,7 @@ class PassiveLogCollector : public ChromeNetLog::ThreadSafeObserverImpl {
private:
virtual Action DoAddEntry(const ChromeNetLog::Entry& entry,
- SourceInfo* out_info);
+ SourceInfo* out_info) OVERRIDE;
DISALLOW_COPY_AND_ASSIGN(DiskCacheEntryTracker);
};
@@ -322,7 +322,7 @@ class PassiveLogCollector : public ChromeNetLog::ThreadSafeObserverImpl {
protected:
virtual Action DoAddEntry(const ChromeNetLog::Entry& entry,
- SourceInfo* out_info);
+ SourceInfo* out_info) OVERRIDE;
private:
DISALLOW_COPY_AND_ASSIGN(MemCacheEntryTracker);
@@ -337,7 +337,7 @@ class PassiveLogCollector : public ChromeNetLog::ThreadSafeObserverImpl {
private:
virtual Action DoAddEntry(const ChromeNetLog::Entry& entry,
- SourceInfo* out_info);
+ SourceInfo* out_info) OVERRIDE;
DISALLOW_COPY_AND_ASSIGN(HttpStreamJobTracker);
};
@@ -350,7 +350,7 @@ class PassiveLogCollector : public ChromeNetLog::ThreadSafeObserverImpl {
private:
virtual Action DoAddEntry(const ChromeNetLog::Entry& entry,
- SourceInfo* out_info);
+ SourceInfo* out_info) OVERRIDE;
DISALLOW_COPY_AND_ASSIGN(ExponentialBackoffThrottlingTracker);
};
@@ -364,7 +364,7 @@ class PassiveLogCollector : public ChromeNetLog::ThreadSafeObserverImpl {
private:
virtual Action DoAddEntry(const ChromeNetLog::Entry& entry,
- SourceInfo* out_info);
+ SourceInfo* out_info) OVERRIDE;
DISALLOW_COPY_AND_ASSIGN(DnsTransactionTracker);
};
@@ -379,7 +379,7 @@ class PassiveLogCollector : public ChromeNetLog::ThreadSafeObserverImpl {
private:
virtual Action DoAddEntry(const ChromeNetLog::Entry& entry,
- SourceInfo* out_info);
+ SourceInfo* out_info) OVERRIDE;
DISALLOW_COPY_AND_ASSIGN(AsyncHostResolverRequestTracker);
};
@@ -395,7 +395,7 @@ class PassiveLogCollector : public ChromeNetLog::ThreadSafeObserverImpl {
private:
virtual Action DoAddEntry(const ChromeNetLog::Entry& entry,
- SourceInfo* out_info);
+ SourceInfo* out_info) OVERRIDE;
DISALLOW_COPY_AND_ASSIGN(UDPSocketTracker);
};
@@ -410,7 +410,7 @@ class PassiveLogCollector : public ChromeNetLog::ThreadSafeObserverImpl {
private:
virtual Action DoAddEntry(const ChromeNetLog::Entry& entry,
- SourceInfo* out_info);
+ SourceInfo* out_info) OVERRIDE;
DISALLOW_COPY_AND_ASSIGN(CertVerifierJobTracker);
};
@@ -423,7 +423,7 @@ class PassiveLogCollector : public ChromeNetLog::ThreadSafeObserverImpl {
const base::TimeTicks& time,
const net::NetLog::Source& source,
net::NetLog::EventPhase phase,
- net::NetLog::EventParameters* params);
+ net::NetLog::EventParameters* params) OVERRIDE;
// Clears all of the passively logged data.
void Clear();

Powered by Google App Engine
This is Rietveld 408576698