Add OVERRIDE to chrome/browser/.

chrome/browser/debugger/devtools_window.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_
 #define CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 39 matching lines @@
       DevToolsAgentHost* worker_agent);
   static DevToolsWindow* CreateDevToolsWindowForWorker(Profile* profile);
   static DevToolsWindow* OpenDevToolsWindow(RenderViewHost* inspected_rvh);
   static DevToolsWindow* ToggleDevToolsWindow(RenderViewHost* inspected_rvh,
                                               DevToolsToggleAction action);
   static void InspectElement(RenderViewHost* inspected_rvh, int x, int y);
 
   virtual ~DevToolsWindow();
 
   // Overridden from DevToolsClientHost.
-  virtual void SendMessageToClient(const IPC::Message& message);
-  virtual void InspectedTabClosing();
-  virtual void TabReplaced(TabContents* new_tab);
-  virtual RenderViewHost* GetClientRenderViewHost();
+  virtual void SendMessageToClient(const IPC::Message& message) OVERRIDE;
+  virtual void InspectedTabClosing() OVERRIDE;
+  virtual void TabReplaced(TabContents* new_tab) OVERRIDE;
+  virtual RenderViewHost* GetClientRenderViewHost() OVERRIDE;
   RenderViewHost* GetRenderViewHost();

[Nico, 2011/11/21 16:03:13]

This is not an override? Is it called by anyone? (If so, maybe add a line of
whitespace above this?)

[Avi (use Gerrit), 2011/11/21 16:16:51]

These megapatches only change OVERRIDE. I haven't investigated what look to be
anomalies.

 
   void Show(DevToolsToggleAction action);
 
   TabContentsWrapper* tab_contents() { return tab_contents_; }
   Browser* browser() { return browser_; }  // For tests.
   bool is_docked() { return docked_; }
 
  private:
   static DevToolsWindow* Create(Profile* profile,
                                 RenderViewHost* inspected_rvh,
                                 bool docked, bool shared_worker_frontend);
   DevToolsWindow(TabContentsWrapper* tab_contents, Profile* profile,
                  RenderViewHost* inspected_rvh, bool docked);
 
   void CreateDevToolsBrowser();
   bool FindInspectedBrowserAndTabIndex(Browser**, int* tab);
   BrowserWindow* GetInspectedBrowserWindow();
   bool IsInspectedBrowserPopupOrPanel();
   void UpdateFrontendAttachedState();
 
   // Overridden from content::NotificationObserver.
   virtual void Observe(int type,
                        const content::NotificationSource& source,
-                       const content::NotificationDetails& details);
+                       const content::NotificationDetails& details) OVERRIDE;
 
   void ScheduleAction(DevToolsToggleAction action);
   void DoAction();
   static GURL GetDevToolsUrl(Profile* profile, bool docked,
                              bool shared_worker_frontend);
   void UpdateTheme();
   void AddDevToolsExtensionsToClient();
   void CallClientFunction(const string16& function_name,
                           const base::Value& arg);
   // Overridden from TabContentsDelegate.
   // Deprecated. Use two-arguments variant instead.
   virtual TabContents* OpenURLFromTab(
       TabContents* source,
       const GURL& url,
       const GURL& referrer,
       WindowOpenDisposition disposition,
       content::PageTransition transition) OVERRIDE;
   virtual TabContents* OpenURLFromTab(TabContents* source,
                                       const OpenURLParams& params) OVERRIDE;
   virtual void AddNewContents(TabContents* source,
                               TabContents* new_contents,
                               WindowOpenDisposition disposition,
                               const gfx::Rect& initial_pos,
-                              bool user_gesture);
-  virtual void CloseContents(TabContents* source) {}
-  virtual bool CanReloadContents(TabContents* source) const;
+                              bool user_gesture) OVERRIDE;
+  virtual void CloseContents(TabContents* source) OVERRIDE {}
+  virtual bool CanReloadContents(TabContents* source) const OVERRIDE;
   virtual bool PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event,
-                                      bool* is_keyboard_shortcut);
-  virtual void HandleKeyboardEvent(const NativeWebKeyboardEvent& event);
-  virtual content::JavaScriptDialogCreator* GetJavaScriptDialogCreator();
+                                      bool* is_keyboard_shortcut) OVERRIDE;
+  virtual void HandleKeyboardEvent(
+      const NativeWebKeyboardEvent& event) OVERRIDE;
+  virtual content::JavaScriptDialogCreator*
+      GetJavaScriptDialogCreator() OVERRIDE;
 
-  virtual void FrameNavigating(const std::string& url) {}
+  virtual void FrameNavigating(const std::string& url) OVERRIDE {}
 
   static DevToolsWindow* ToggleDevToolsWindow(RenderViewHost* inspected_rvh,
                                               bool force_open,
                                               DevToolsToggleAction action);
   static DevToolsWindow* AsDevToolsWindow(DevToolsClientHost*);
 
   // RenderViewHostObserver overrides.
   virtual void RenderViewHostDestroyed(RenderViewHost* rvh) OVERRIDE;
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
 
@@ skipping 11 matching lines @@
   TabContentsWrapper* tab_contents_;
   Browser* browser_;
   bool docked_;
   bool is_loaded_;
   DevToolsToggleAction action_on_load_;
   content::NotificationRegistrar registrar_;
   DISALLOW_COPY_AND_ASSIGN(DevToolsWindow);
 };
 
 #endif  // CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_