Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8602002: Move some webkit_glue embedder functions into WebKitPlatformSupport virtual methods (Closed)

Created:
9 years, 1 month ago by piman
Modified:
9 years, 1 month ago
Reviewers:
Dirk Pranke, jam, tony
CC:
chromium-reviews, pam+watch_chromium.org, jonathan.backer, Ian Vollick, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Visibility:
Public.

Description

Move some webkit_glue embedder functions into WebKitPlatformSupport virtual methods This moves the functions into a pattern that is component-friendly. BUG=98755 TEST=chrome test_shell test_shell_tests browser_tests DumpRenderTree Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111101

Patch Set 1 : style #

Total comments: 6

Patch Set 2 : correct review items #

Total comments: 6

Patch Set 3 : fix review nits #

Total comments: 2

Patch Set 4 : rename files #

Patch Set 5 : rebase #

Patch Set 6 : copyright year #

Unified diffs Side-by-side diffs Delta from patch set Stats (+485 lines, -353 lines) Patch
M content/browser/idbbindingutilities_browsertest.cc View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/in_process_webkit/browser_webkitplatformsupport_impl.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_sandbox_host_linux.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
A content/common/webkitplatformsupport_impl.h View 1 2 3 1 chunk +38 lines, -0 lines 0 comments Download
A content/common/webkitplatformsupport_impl.cc View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_webkitplatformsupport_impl.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
D content/renderer/renderer_glue.cc View 1 2 3 4 1 chunk +0 lines, -55 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 2 3 4 2 chunks +36 lines, -38 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M content/utility/utility_thread_impl.h View 1 2 chunks +1 line, -4 lines 0 comments Download
M content/utility/utility_thread_impl.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/worker/worker_webkitplatformsupport_impl.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/compositor/test/compositor_test_support.cc View 2 chunks +33 lines, -2 lines 0 comments Download
M webkit/glue/resource_loader_bridge.h View 4 chunks +9 lines, -12 lines 0 comments Download
M webkit/glue/webkit_glue.h View 1 2 3 4 2 chunks +0 lines, -29 lines 0 comments Download
M webkit/glue/webkitplatformsupport_impl.h View 3 chunks +35 lines, -0 lines 0 comments Download
M webkit/glue/webkitplatformsupport_impl.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M webkit/glue/websocketstreamhandle_bridge.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/glue/websocketstreamhandle_impl.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M webkit/glue/websocketstreamhandle_impl.cc View 5 chunks +11 lines, -6 lines 0 comments Download
M webkit/glue/weburlloader_impl.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M webkit/glue/weburlloader_impl.cc View 1 2 3 4 7 chunks +11 lines, -7 lines 0 comments Download
M webkit/support/platform_support_android.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M webkit/support/platform_support_linux.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M webkit/support/platform_support_mac.mm View 4 chunks +3 lines, -6 lines 0 comments Download
M webkit/support/platform_support_win.cc View 1 2 3 4 5 5 chunks +4 lines, -7 lines 0 comments Download
M webkit/support/test_webkit_platform_support.h View 1 3 chunks +48 lines, -34 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 3 chunks +37 lines, -0 lines 0 comments Download
M webkit/support/webkit_support_glue.cc View 1 2 3 4 1 chunk +0 lines, -23 lines 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.h View 2 chunks +5 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 2 chunks +6 lines, -12 lines 0 comments Download
M webkit/tools/test_shell/simple_socket_stream_bridge.h View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/simple_socket_stream_bridge.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 1 2 3 4 2 chunks +0 lines, -28 lines 0 comments Download
M webkit/tools/test_shell/test_shell_gtk.cc View 1 2 3 4 3 chunks +3 lines, -6 lines 0 comments Download
M webkit/tools/test_shell/test_shell_mac.mm View 4 chunks +5 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webkit_init.h View 1 2 3 4 3 chunks +44 lines, -30 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webkit_init.cc View 1 2 3 4 2 chunks +38 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_win.cc View 4 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
piman
dpranke: please review jam: OWNERS for content/{browser,common,utility,worker} tony: OWNERS for webkit/
9 years, 1 month ago (2011-11-19 02:19:13 UTC) #1
jam
http://codereview.chromium.org/8602002/diff/11001/chrome/browser/idbbindingutilities_browsertest.cc File chrome/browser/idbbindingutilities_browsertest.cc (right): http://codereview.chromium.org/8602002/diff/11001/chrome/browser/idbbindingutilities_browsertest.cc#newcode11 chrome/browser/idbbindingutilities_browsertest.cc:11: #include "content/common/content_webkitplatformsupport_impl.h" nit: files in chrome should only be ...
9 years, 1 month ago (2011-11-19 23:13:46 UTC) #2
Dirk Pranke
lgtm w/ jam's comments addressed. Nice cleanup.
9 years, 1 month ago (2011-11-21 20:17:15 UTC) #3
piman
http://codereview.chromium.org/8602002/diff/11001/chrome/browser/idbbindingutilities_browsertest.cc File chrome/browser/idbbindingutilities_browsertest.cc (right): http://codereview.chromium.org/8602002/diff/11001/chrome/browser/idbbindingutilities_browsertest.cc#newcode11 chrome/browser/idbbindingutilities_browsertest.cc:11: #include "content/common/content_webkitplatformsupport_impl.h" On 2011/11/19 23:13:46, John Abd-El-Malek wrote: > ...
9 years, 1 month ago (2011-11-21 22:05:04 UTC) #4
tony
LGTM, just some style nits. http://codereview.chromium.org/8602002/diff/17001/webkit/glue/websocketstreamhandle_impl.h File webkit/glue/websocketstreamhandle_impl.h (right): http://codereview.chromium.org/8602002/diff/17001/webkit/glue/websocketstreamhandle_impl.h#newcode17 webkit/glue/websocketstreamhandle_impl.h:17: WebSocketStreamHandleImpl(WebKitPlatformSupportImpl* platform); explicit http://codereview.chromium.org/8602002/diff/17001/webkit/glue/weburlloader_impl.h ...
9 years, 1 month ago (2011-11-21 22:26:19 UTC) #5
piman
http://codereview.chromium.org/8602002/diff/17001/webkit/glue/websocketstreamhandle_impl.h File webkit/glue/websocketstreamhandle_impl.h (right): http://codereview.chromium.org/8602002/diff/17001/webkit/glue/websocketstreamhandle_impl.h#newcode17 webkit/glue/websocketstreamhandle_impl.h:17: WebSocketStreamHandleImpl(WebKitPlatformSupportImpl* platform); On 2011/11/21 22:26:19, tony wrote: > explicit ...
9 years, 1 month ago (2011-11-21 22:43:27 UTC) #6
piman
(Still waiting for John's OWNERS LGTM in content/)
9 years, 1 month ago (2011-11-22 00:25:31 UTC) #7
jam
lgtm http://codereview.chromium.org/8602002/diff/31001/content/common/content_webkitplatformsupport_impl.h File content/common/content_webkitplatformsupport_impl.h (right): http://codereview.chromium.org/8602002/diff/31001/content/common/content_webkitplatformsupport_impl.h#newcode1 content/common/content_webkitplatformsupport_impl.h:1: // Copyright (c) 2011 The Chromium Authors. All ...
9 years, 1 month ago (2011-11-22 01:24:26 UTC) #8
piman
http://codereview.chromium.org/8602002/diff/31001/content/common/content_webkitplatformsupport_impl.h File content/common/content_webkitplatformsupport_impl.h (right): http://codereview.chromium.org/8602002/diff/31001/content/common/content_webkitplatformsupport_impl.h#newcode1 content/common/content_webkitplatformsupport_impl.h:1: // Copyright (c) 2011 The Chromium Authors. All rights ...
9 years, 1 month ago (2011-11-22 01:53:39 UTC) #9
piman
FYI, rebasing to top-of-trunk, renderer_glue.cc ends up empty, so I removed it altogether.
9 years, 1 month ago (2011-11-22 04:01:42 UTC) #10
Dirk Pranke
nice!
9 years, 1 month ago (2011-11-22 04:26:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8602002/36001
9 years, 1 month ago (2011-11-22 04:30:26 UTC) #12
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 05:42:38 UTC) #13 
Change committed as 111101

Powered by Google App Engine
This is Rietveld 408576698