Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: webkit/tools/test_shell/simple_socket_stream_bridge.h

Issue 8602002: Move some webkit_glue embedder functions into WebKitPlatformSupport virtual methods (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: correct review items Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_TOOLS_TEST_SHELL_SIMPLE_SOCKET_STREAM_BRIDGE_H_ 5 #ifndef WEBKIT_TOOLS_TEST_SHELL_SIMPLE_SOCKET_STREAM_BRIDGE_H_
6 #define WEBKIT_TOOLS_TEST_SHELL_SIMPLE_SOCKET_STREAM_BRIDGE_H_ 6 #define WEBKIT_TOOLS_TEST_SHELL_SIMPLE_SOCKET_STREAM_BRIDGE_H_
7 7
8 namespace net { 8 namespace net {
9 class URLRequestContext; 9 class URLRequestContext;
10 } // namespace net 10 } // namespace net
11 11
12 namespace WebKit {
13 class WebSocketStreamHandle;
14 } // namespace WebKit
15
16 namespace webkit_glue {
17 class WebSocketStreamHandleDelegate;
18 class WebSocketStreamHandleBridge;
19 } // namespace webkit_glue
20
12 class SimpleSocketStreamBridge { 21 class SimpleSocketStreamBridge {
13 public: 22 public:
14 static void InitializeOnIOThread(net::URLRequestContext* request_context); 23 static void InitializeOnIOThread(net::URLRequestContext* request_context);
15 static void Cleanup(); 24 static void Cleanup();
25 static webkit_glue::WebSocketStreamHandleBridge* Create(
26 WebKit::WebSocketStreamHandle* handle,
27 webkit_glue::WebSocketStreamHandleDelegate* delegate);
16 }; 28 };
tony 2011/11/21 22:26:19 Nit: Should this have a private constructor and DI
piman 2011/11/21 22:43:27 The class isn't even meant to be instanced. I adde
17 29
18 #endif // WEBKIT_TOOLS_TEST_SHELL_SIMPLE_SOCKET_STREAM_BRIDGE_H_ 30 #endif // WEBKIT_TOOLS_TEST_SHELL_SIMPLE_SOCKET_STREAM_BRIDGE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698