Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Unified Diff: webkit/tools/test_shell/test_shell_webkit_init.h

Issue 8602002: Move some webkit_glue embedder functions into WebKitPlatformSupport virtual methods (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: copyright year Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/tools/test_shell/test_shell_mac.mm ('k') | webkit/tools/test_shell/test_shell_webkit_init.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/tools/test_shell/test_shell_webkit_init.h
diff --git a/webkit/tools/test_shell/test_shell_webkit_init.h b/webkit/tools/test_shell/test_shell_webkit_init.h
index 4063b94919ac1236b339dee2aefa7fa5ed1edd63..9dbc70d77710a6c656d70de2be8f42baada66ca2 100644
--- a/webkit/tools/test_shell/test_shell_webkit_init.h
+++ b/webkit/tools/test_shell/test_shell_webkit_init.h
@@ -5,6 +5,7 @@
#ifndef WEBKIT_TOOLS_TEST_SHELL_TEST_SHELL_WEBKIT_INIT_H_
#define WEBKIT_TOOLS_TEST_SHELL_TEST_SHELL_WEBKIT_INIT_H_
+#include "base/compiler_specific.h"
#include "base/utf_string_conversions.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebIDBFactory.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebIDBKey.h"
@@ -35,60 +36,62 @@ class TestShellWebKitInit : public webkit_glue::WebKitPlatformSupportImpl {
explicit TestShellWebKitInit(bool layout_test_mode);
virtual ~TestShellWebKitInit();
- virtual WebKit::WebMimeRegistry* mimeRegistry();
- virtual WebKit::WebClipboard* clipboard();
- virtual WebKit::WebFileUtilities* fileUtilities();
- virtual WebKit::WebSandboxSupport* sandboxSupport();
- virtual WebKit::WebCookieJar* cookieJar();
- virtual WebKit::WebBlobRegistry* blobRegistry();
- virtual WebKit::WebFileSystem* fileSystem();
- virtual bool sandboxEnabled();
+ virtual WebKit::WebMimeRegistry* mimeRegistry() OVERRIDE;
+ virtual WebKit::WebClipboard* clipboard() OVERRIDE;
+ virtual WebKit::WebFileUtilities* fileUtilities() OVERRIDE;
+ virtual WebKit::WebSandboxSupport* sandboxSupport() OVERRIDE;
+ virtual WebKit::WebCookieJar* cookieJar() OVERRIDE;
+ virtual WebKit::WebBlobRegistry* blobRegistry() OVERRIDE;
+ virtual WebKit::WebFileSystem* fileSystem() OVERRIDE;
+ virtual bool sandboxEnabled() OVERRIDE;
virtual WebKit::WebKitPlatformSupport::FileHandle databaseOpenFile(
- const WebKit::WebString& vfs_file_name, int desired_flags);
+ const WebKit::WebString& vfs_file_name, int desired_flags) OVERRIDE;
virtual int databaseDeleteFile(const WebKit::WebString& vfs_file_name,
- bool sync_dir);
+ bool sync_dir) OVERRIDE;
virtual long databaseGetFileAttributes(
- const WebKit::WebString& vfs_file_name);
+ const WebKit::WebString& vfs_file_name) OVERRIDE;
virtual long long databaseGetFileSize(
- const WebKit::WebString& vfs_file_name);
+ const WebKit::WebString& vfs_file_name) OVERRIDE;
virtual long long databaseGetSpaceAvailableForOrigin(
- const WebKit::WebString& origin_identifier);
+ const WebKit::WebString& origin_identifier) OVERRIDE;
virtual unsigned long long visitedLinkHash(const char* canonicalURL,
- size_t length);
- virtual bool isLinkVisited(unsigned long long linkHash);
- virtual WebKit::WebMessagePortChannel* createMessagePortChannel();
- virtual void prefetchHostName(const WebKit::WebString&);
- virtual WebKit::WebData loadResource(const char* name);
+ size_t length) OVERRIDE;
+ virtual bool isLinkVisited(unsigned long long linkHash) OVERRIDE;
+ virtual WebKit::WebMessagePortChannel* createMessagePortChannel() OVERRIDE;
+ virtual void prefetchHostName(const WebKit::WebString&) OVERRIDE;
+ virtual WebKit::WebData loadResource(const char* name) OVERRIDE;
virtual WebKit::WebString queryLocalizedString(
- WebKit::WebLocalizedString::Name name);
+ WebKit::WebLocalizedString::Name name) OVERRIDE;
virtual WebKit::WebString queryLocalizedString(
- WebKit::WebLocalizedString::Name name, const WebKit::WebString& value);
+ WebKit::WebLocalizedString::Name name,
+ const WebKit::WebString& value) OVERRIDE;
virtual WebKit::WebString queryLocalizedString(
WebKit::WebLocalizedString::Name name,
- const WebKit::WebString& value1, const WebKit::WebString& value2);
+ const WebKit::WebString& value1,
+ const WebKit::WebString& value2) OVERRIDE;
- virtual WebKit::WebString defaultLocale();
+ virtual WebKit::WebString defaultLocale() OVERRIDE;
virtual WebKit::WebStorageNamespace* createLocalStorageNamespace(
- const WebKit::WebString& path, unsigned quota);
+ const WebKit::WebString& path, unsigned quota) OVERRIDE;
virtual void dispatchStorageEvent(const WebKit::WebString& key,
const WebKit::WebString& old_value,
const WebKit::WebString& new_value,
const WebKit::WebString& origin,
const WebKit::WebURL& url,
- bool is_local_storage);
- virtual WebKit::WebIDBFactory* idbFactory();
+ bool is_local_storage) OVERRIDE;
+ virtual WebKit::WebIDBFactory* idbFactory() OVERRIDE;
virtual void createIDBKeysFromSerializedValuesAndKeyPath(
const WebKit::WebVector<WebKit::WebSerializedScriptValue>& values,
const WebKit::WebString& keyPath,
- WebKit::WebVector<WebKit::WebIDBKey>& keys_out);
+ WebKit::WebVector<WebKit::WebIDBKey>& keys_out) OVERRIDE;
virtual WebKit::WebSerializedScriptValue injectIDBKeyIntoSerializedValue(
const WebKit::WebIDBKey& key,
const WebKit::WebSerializedScriptValue& value,
- const WebKit::WebString& keyPath);
+ const WebKit::WebString& keyPath) OVERRIDE;
#if defined(OS_WIN)
@@ -97,13 +100,24 @@ class TestShellWebKitInit : public webkit_glue::WebKitPlatformSupportImpl {
engine : WebKitPlatformSupportImpl::themeEngine();
}
- virtual WebKit::WebThemeEngine *themeEngine() {
+ virtual WebKit::WebThemeEngine *themeEngine() OVERRIDE {
return active_theme_engine_;
}
#endif
- virtual WebKit::WebSharedWorkerRepository* sharedWorkerRepository();
- virtual WebKit::WebGraphicsContext3D* createGraphicsContext3D();
+ virtual WebKit::WebSharedWorkerRepository* sharedWorkerRepository() OVERRIDE;
+ virtual WebKit::WebGraphicsContext3D* createGraphicsContext3D() OVERRIDE;
+
+ virtual string16 GetLocalizedString(int message_id) OVERRIDE;
+ virtual base::StringPiece GetDataResource(int resource_id) OVERRIDE;
+ virtual void GetPlugins(bool refresh,
+ std::vector<webkit::WebPluginInfo>* plugins) OVERRIDE;
+ virtual webkit_glue::ResourceLoaderBridge* CreateResourceLoader(
+ const webkit_glue::ResourceLoaderBridge::RequestInfo& request_info)
+ OVERRIDE;
+ virtual webkit_glue::WebSocketStreamHandleBridge* CreateWebSocketBridge(
+ WebKit::WebSocketStreamHandle* handle,
+ webkit_glue::WebSocketStreamHandleDelegate* delegate) OVERRIDE;
private:
scoped_ptr<webkit_glue::SimpleWebMimeRegistryImpl> mime_registry_;
« no previous file with comments | « webkit/tools/test_shell/test_shell_mac.mm ('k') | webkit/tools/test_shell/test_shell_webkit_init.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698