Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: webkit/glue/webkitplatformsupport_impl.h

Issue 8602002: Move some webkit_glue embedder functions into WebKitPlatformSupport virtual methods (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: copyright year Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/webkit_glue.h ('k') | webkit/glue/webkitplatformsupport_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webkitplatformsupport_impl.h
diff --git a/webkit/glue/webkitplatformsupport_impl.h b/webkit/glue/webkitplatformsupport_impl.h
index d73e2426633b7a886db97b300d0f250531513472..7ecbd3ad922f39f41239d56cf783a2d835c9cf44 100644
--- a/webkit/glue/webkitplatformsupport_impl.h
+++ b/webkit/glue/webkitplatformsupport_impl.h
@@ -9,6 +9,7 @@
#include "base/threading/thread_local_storage.h"
#include "base/timer.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebKitPlatformSupport.h"
+#include "webkit/glue/resource_loader_bridge.h"
#if defined(OS_WIN)
#include "webkit/glue/webthemeengine_impl_win.h"
#elif defined(OS_MACOSX)
@@ -20,8 +21,19 @@
class MessageLoop;
+namespace webkit {
+struct WebPluginInfo;
+}
+
+namespace WebKit {
+class WebSocketStreamHandle;
+}
+
namespace webkit_glue {
+class WebSocketStreamHandleDelegate;
+class WebSocketStreamHandleBridge;
+
class WebKitPlatformSupportImpl : public WebKit::WebKitPlatformSupport {
public:
WebKitPlatformSupportImpl();
@@ -82,6 +94,29 @@ class WebKitPlatformSupportImpl : public WebKit::WebKitPlatformSupport {
virtual WebKit::WebThread* createThread(const char* name);
virtual WebKit::WebThread* currentThread();
+
+ // Embedder functions. The following are not implemented by the glue layer and
+ // need to be specialized by the embedder.
+
+ // Gets a localized string given a message id. Returns an empty string if the
+ // message id is not found.
+ virtual string16 GetLocalizedString(int message_id) = 0;
+
+ // Returns the raw data for a resource. This resource must have been
+ // specified as BINDATA in the relevant .rc file.
+ virtual base::StringPiece GetDataResource(int resource_id) = 0;
+
+ // Returns the list of plugins.
+ virtual void GetPlugins(bool refresh,
+ std::vector<webkit::WebPluginInfo>* plugins) = 0;
+ // Creates a ResourceLoaderBridge.
+ virtual ResourceLoaderBridge* CreateResourceLoader(
+ const ResourceLoaderBridge::RequestInfo& request_info) = 0;
+ // Creates a WebSocketStreamHandleBridge.
+ virtual WebSocketStreamHandleBridge* CreateWebSocketBridge(
+ WebKit::WebSocketStreamHandle* handle,
+ WebSocketStreamHandleDelegate* delegate) = 0;
+
void SuspendSharedTimer();
void ResumeSharedTimer();
« no previous file with comments | « webkit/glue/webkit_glue.h ('k') | webkit/glue/webkitplatformsupport_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698