Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8587009: Add OVERRIDE to content/. (Closed)

Created:
9 years, 1 month ago by Avi (use Gerrit)
Modified:
9 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, vrk (LEFT CHROMIUM), yusukes+watch_chromium.org, jam, yoshiki+watch_chromium.org, annacc+watch_chromium.org, dmazzoni+watch_chromium.org, ajwong+watch_chromium.org, kinuko+watch, cbentzel+watch_chromium.org, aboxhall+watch_chromium.org, acolwell+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, scherkus (not reviewing), ihf+watch_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, dtseng+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, penghuang+watch_chromium.org, yuzo+watch_chromium.org, dpranke-watch+content_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, michaeln, hclam+watch_chromium.org, hashimoto+watch_chromium.org, davidbarr+watch_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., James Su
Visibility:
Public.

Description

Add OVERRIDE to content/. BUG=104314 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110544

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+887 lines, -756 lines) Patch
M content/browser/accessibility/browser_accessibility_mac.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_mac.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/appcache/appcache_dispatcher_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/appcache_frontend_proxy.h View 1 2 chunks +9 lines, -8 lines 0 comments Download
M content/browser/appcache/chrome_appcache_service.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/browser_child_process_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_process_sub_thread.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/cert_store.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/debugger/devtools_http_protocol_handler.h View 2 chunks +10 lines, -8 lines 0 comments Download
M content/browser/debugger/devtools_manager.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/debugger/render_view_devtools_agent_host.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/debugger/worker_devtools_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/device_orientation/accelerometer_mac.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/device_orientation/message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/device_orientation/provider_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/download/download_resource_handler.h View 1 1 chunk +19 lines, -10 lines 0 comments Download
M content/browser/download/drag_download_file.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/download/drag_download_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/download/save_file_resource_handler.h View 1 chunk +19 lines, -10 lines 0 comments Download
M content/browser/geolocation/arbitrator_dependency_factories_for_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/arbitrator_dependency_factory.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/geolocation/core_location_provider_mac.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/geolocation/geolocation_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/geolocation/location_arbitrator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/mock_location_provider.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/geolocation/network_location_provider.h View 2 chunks +8 lines, -8 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider_common.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider_mac.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/host_zoom_map.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.h View 1 chunk +5 lines, -4 lines 0 comments Download
M content/browser/in_process_webkit/webkit_thread.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/mach_broker_mac.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/mime_registry_message_filter.h View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/net/browser_online_state_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/url_request_failed_dns_job.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/url_request_mock_http_job.h View 1 chunk +5 lines, -4 lines 0 comments Download
M content/browser/net/url_request_slow_download_job.h View 1 chunk +6 lines, -4 lines 0 comments Download
M content/browser/net/url_request_slow_http_job.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/notification_service_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/plugin_loader_posix.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_process_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/plugin_service.h View 1 chunk +5 lines, -3 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/async_resource_handler.h View 1 chunk +22 lines, -11 lines 0 comments Download
M content/browser/renderer_host/backing_store_gtk.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/backing_store_mac.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/backing_store_skia.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/backing_store_win.h View 1 chunk +10 lines, -9 lines 0 comments Download
M content/browser/renderer_host/blob_message_filter.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/browser_render_process_host.h View 2 chunks +18 lines, -17 lines 0 comments Download
M content/browser/renderer_host/buffered_resource_handler.h View 1 chunk +19 lines, -10 lines 0 comments Download
M content/browser/renderer_host/clipboard_message_filter.h View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/cross_site_resource_handler.h View 1 chunk +19 lines, -10 lines 0 comments Download
M content/browser/renderer_host/database_message_filter.h View 2 chunks +9 lines, -7 lines 0 comments Download
M content/browser/renderer_host/file_utilities_message_filter.h View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/gpu_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_input_device_manager.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.h View 1 chunk +9 lines, -9 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_sync_writer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.h View 1 chunk +8 lines, -8 lines 0 comments Download
M content/browser/renderer_host/media/audio_sync_reader.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.h View 1 chunk +9 lines, -8 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.h View 1 chunk +11 lines, -8 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host.h View 1 chunk +8 lines, -8 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/mock_render_process_host.h View 1 chunk +17 lines, -16 lines 0 comments Download
M content/browser/renderer_host/pepper_file_message_filter.h View 1 chunk +5 lines, -4 lines 0 comments Download
M content/browser/renderer_host/pepper_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/quota_dispatcher_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/redirect_to_file_resource_handler.h View 1 chunk +20 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/resource_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/socket_stream_dispatcher_host.h View 1 chunk +8 lines, -7 lines 0 comments Download
M content/browser/renderer_host/sync_resource_handler.h View 1 chunk +20 lines, -10 lines 0 comments Download
M content/browser/renderer_host/test_backing_store.h View 1 chunk +9 lines, -8 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 1 4 chunks +10 lines, -9 lines 0 comments Download
M content/browser/renderer_host/text_input_client_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/x509_user_cert_resource_handler.h View 1 chunk +22 lines, -11 lines 0 comments Download
M content/browser/resolve_proxy_msg_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/site_instance.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/speech_input_dispatcher_host.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/speech/speech_recognizer.h View 1 chunk +6 lines, -5 lines 0 comments Download
M content/browser/ssl/ssl_cert_error_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/ssl/ssl_client_auth_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ssl/ssl_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/interstitial_page.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/popup_menu_helper_mac.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/render_view_host_manager.h View 1 chunk +5 lines, -4 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 5 chunks +18 lines, -16 lines 0 comments Download
M content/browser/tab_contents/tab_contents_observer.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/trace_message_filter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/trace_subscriber_stdio.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/utility_process_host.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/worker_host/worker_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/worker_host/worker_process_host.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/appcache/appcache_backend_proxy.h View 1 chunk +14 lines, -12 lines 0 comments Download
M content/common/appcache/appcache_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/child_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/child_thread.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/child_trace_message_filter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/db_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/file_system/file_system_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/file_system/webfilesystem_callback_dispatcher.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/common/file_system/webfilewriter_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/gpu/gpu_channel.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_channel_manager.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/hi_res_timer_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/message_router.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/np_channel_base.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/npobject_proxy.h View 3 chunks +5 lines, -5 lines 0 comments Download
M content/common/npobject_stub.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/common/pepper_plugin_registry.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/quota_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/resource_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/socket_stream_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/webmessageportchannel_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_child_thread.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/gpu/gpu_watchdog_thread.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/plugin/plugin_channel.h View 3 chunks +7 lines, -7 lines 0 comments Download
M content/plugin/plugin_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/webplugin_accelerated_surface_proxy_mac.h View 2 chunks +6 lines, -5 lines 0 comments Download
M content/plugin/webplugin_delegate_stub.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/plugin/webplugin_proxy.h View 4 chunks +24 lines, -22 lines 0 comments Download
M content/ppapi_plugin/ppapi_webkit_thread.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/renderer/render_view_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/device_orientation_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/devtools_agent.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/devtools_agent_filter.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/geolocation_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/command_buffer_proxy.h View 1 chunk +18 lines, -17 lines 0 comments Download
M content/renderer/gpu/gpu_channel_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/gpu/input_event_filter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/gpu/transport_texture_service.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/indexed_db_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/audio_device.h View 2 chunks +7 lines, -6 lines 0 comments Download
M content/renderer/media/audio_input_device.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/media/audio_input_message_filter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/media/audio_message_filter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/media/audio_renderer_impl.h View 2 chunks +18 lines, -15 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_impl.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/render_media_log.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_capture_impl.h View 1 chunk +12 lines, -12 lines 0 comments Download
M content/renderer/media/video_capture_message_filter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/media/video_capture_module_impl.h View 1 chunk +7 lines, -7 lines 0 comments Download
M content/renderer/media/webrtc_audio_device_impl.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/mhtml_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/notification_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/p2p/ipc_socket_factory.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/p2p/socket_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper_platform_context_3d_impl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/renderer/pepper_platform_video_decoder_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.h View 1 3 chunks +16 lines, -16 lines 0 comments Download
M content/renderer/plugin_channel_host.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/render_process_impl.h View 1 2 chunks +6 lines, -5 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 1 4 chunks +21 lines, -20 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.h View 3 chunks +14 lines, -13 lines 0 comments Download
M content/renderer/renderer_accessibility.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/renderer_webapplicationcachehost_impl.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/renderer_webaudiodevice_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/speech_input_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/text_input_client_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/webplugin_delegate_proxy.h View 2 chunks +20 lines, -20 lines 0 comments Download
M content/renderer/websharedworker_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_browser_main.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/browser_test.h View 1 chunk +4 lines, -2 lines 0 comments Download
M content/test/mock_render_process.h View 1 2 chunks +6 lines, -5 lines 0 comments Download
M content/test/render_view_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/test_notification_tracker.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/test/webrtc_audio_device_test.h View 3 chunks +5 lines, -5 lines 0 comments Download
M content/worker/websharedworker_stub.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/worker/worker_thread.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Avi (use Gerrit)
Just adding OVERRIDE, nothing else.
9 years, 1 month ago (2011-11-16 22:59:49 UTC) #1
jam
9 years, 1 month ago (2011-11-17 01:29:43 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698