base::Bind: Convert HostResolver::Resolve.

base::Bind: Convert HostResolver::Resolve.

BUG=none
TEST=none

R=willchan@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110333

[James Hawkins, 2011-11-12 20:58:10]

Hey Will,

I apologize for the length of this CL, but unfortunately it could not be avoided
:-/

It is not quite finished: I don't yet have a solution for
host_resolver_impl_unittest.cc:1242 - ResolveWithinCallback.

Any suggestions are welcome.

[willchan no longer on Chromium, 2011-11-14 16:45:12]

Did my comment in host_resolver_impl_unittest.cc solve the issue? I'm not too
clear on what the problem is, can you explain?

http://codereview.chromium.org/8549004/diff/1/net/base/host_resolver_impl.cc
File net/base/host_resolver_impl.cc (right):

http://codereview.chromium.org/8549004/diff/1/net/base/host_resolver_impl.cc#...
net/base/host_resolver_impl.cc:1139: DCHECK_EQ(false, callback.is_null());
DCHECK(!callback.is_null())? What you have is fine too, just looks a bit weird.

http://codereview.chromium.org/8549004/diff/1/net/base/host_resolver_impl_uni...
File net/base/host_resolver_impl_unittest.cc (right):

http://codereview.chromium.org/8549004/diff/1/net/base/host_resolver_impl_uni...
net/base/host_resolver_impl_unittest.cc:1250: //callback_.RunWithParams(params);
Change this to callback_.callback()->Run(params.a)?

http://codereview.chromium.org/8549004/diff/1/net/base/mapped_host_resolver.cc
File net/base/mapped_host_resolver.cc (right):

http://codereview.chromium.org/8549004/diff/1/net/base/mapped_host_resolver.c...
net/base/mapped_host_resolver.cc:28: DCHECK_EQ(false, callback.is_null());
I'm going to stop nitting this pattern now. Just pointing out another instance
of DCHECK_EQ(false, ...).

[James Hawkins, 2011-11-15 23:34:33]

http://codereview.chromium.org/8549004/diff/1/net/base/host_resolver_impl_uni...
File net/base/host_resolver_impl_unittest.cc (right):

http://codereview.chromium.org/8549004/diff/1/net/base/host_resolver_impl_uni...
net/base/host_resolver_impl_unittest.cc:1250: //callback_.RunWithParams(params);
On 2011/11/14 16:45:12, willchan wrote:
> Change this to callback_.callback()->Run(params.a)?

Unfortunately the issue is that Resolve takes a CompletionCallback which is now
a typedef for base::Calback<...> which cannot be inherited from, so we can't use
ResolveWithinCallback (as it is written) at all.

[willchan no longer on Chromium, 2011-11-16 00:08:00]

http://codereview.chromium.org/8549004/diff/1/net/base/host_resolver_impl_uni...
File net/base/host_resolver_impl_unittest.cc (right):

http://codereview.chromium.org/8549004/diff/1/net/base/host_resolver_impl_uni...
net/base/host_resolver_impl_unittest.cc:1250: //callback_.RunWithParams(params);
On 2011/11/15 23:34:33, James Hawkins wrote:
> On 2011/11/14 16:45:12, willchan wrote:
> > Change this to callback_.callback()->Run(params.a)?
> 
> Unfortunately the issue is that Resolve takes a CompletionCallback which is
now
> a typedef for base::Calback<...> which cannot be inherited from, so we can't
use
> ResolveWithinCallback (as it is written) at all.

Oh, you probably want to do the same transformation I did for
OldTestCompletionCallback=>TestCompletionCallback. Check out
net/base/test_completion_callback.h.

[James Hawkins, 2011-11-16 00:49:53]

http://codereview.chromium.org/8549004/diff/1/net/base/host_resolver_impl_uni...
File net/base/host_resolver_impl_unittest.cc (right):

http://codereview.chromium.org/8549004/diff/1/net/base/host_resolver_impl_uni...
net/base/host_resolver_impl_unittest.cc:1250: //callback_.RunWithParams(params);
On 2011/11/16 00:08:01, willchan wrote:
> On 2011/11/15 23:34:33, James Hawkins wrote:
> > On 2011/11/14 16:45:12, willchan wrote:
> > > Change this to callback_.callback()->Run(params.a)?
> > 
> > Unfortunately the issue is that Resolve takes a CompletionCallback which is
> now
> > a typedef for base::Calback<...> which cannot be inherited from, so we can't
> use
> > ResolveWithinCallback (as it is written) at all.
> 
> Oh, you probably want to do the same transformation I did for
> OldTestCompletionCallback=>TestCompletionCallback. Check out
> net/base/test_completion_callback.h.

Cool, done.

[willchan no longer on Chromium, 2011-11-16 00:53:02]

lgtm

[commit-bot: I haz the power, 2011-11-16 17:30:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jhawkins@chromium.org/8549004/7001

[commit-bot: I haz the power, 2011-11-16 17:31:05]

Can't process patch for file net/base/host_resolver_impl.h.
File's status is None, patchset upload is incomplete.

[commit-bot: I haz the power, 2011-11-16 18:38:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jhawkins@chromium.org/8549004/12001

[commit-bot: I haz the power, 2011-11-16 18:38:33]

Can't process patch for file net/proxy/sync_host_resolver_bridge_unittest.cc.
File's status is None, patchset upload is incomplete.