Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: net/base/single_request_host_resolver.cc

Issue 8549004: base::Bind: Convert HostResolver::Resolve. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/base/single_request_host_resolver.h" 5 #include "net/base/single_request_host_resolver.h"
6 6
7 #include "base/bind.h"
8 #include "base/bind_helpers.h"
7 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
8 #include "base/logging.h" 10 #include "base/logging.h"
9 #include "net/base/net_errors.h" 11 #include "net/base/net_errors.h"
10 12
11 namespace net { 13 namespace net {
12 14
13 SingleRequestHostResolver::SingleRequestHostResolver(HostResolver* resolver) 15 SingleRequestHostResolver::SingleRequestHostResolver(HostResolver* resolver)
14 : resolver_(resolver), 16 : resolver_(resolver),
15 cur_request_(NULL), 17 cur_request_(NULL),
16 cur_request_callback_(NULL), 18 ALLOW_THIS_IN_INITIALIZER_LIST(callback_(
17 ALLOW_THIS_IN_INITIALIZER_LIST( 19 base::Bind(&SingleRequestHostResolver::OnResolveCompletion,
18 callback_(this, &SingleRequestHostResolver::OnResolveCompletion)) { 20 base::Unretained(this)))) {
19 DCHECK(resolver_ != NULL); 21 DCHECK(resolver_ != NULL);
20 } 22 }
21 23
22 SingleRequestHostResolver::~SingleRequestHostResolver() { 24 SingleRequestHostResolver::~SingleRequestHostResolver() {
23 Cancel(); 25 Cancel();
24 } 26 }
25 27
26 int SingleRequestHostResolver::Resolve(const HostResolver::RequestInfo& info, 28 int SingleRequestHostResolver::Resolve(
27 AddressList* addresses, 29 const HostResolver::RequestInfo& info, AddressList* addresses,
28 OldCompletionCallback* callback, 30 const CompletionCallback& callback, const BoundNetLog& net_log) {
29 const BoundNetLog& net_log) {
30 DCHECK(addresses); 31 DCHECK(addresses);
31 DCHECK(callback); 32 DCHECK_EQ(false, callback.is_null());
32 DCHECK(!cur_request_callback_) << "resolver already in use"; 33 DCHECK(cur_request_callback_.is_null()) << "resolver already in use";
33 34
34 HostResolver::RequestHandle request = NULL; 35 HostResolver::RequestHandle request = NULL;
35 36
36 // We need to be notified of completion before |callback| is called, so that 37 // We need to be notified of completion before |callback| is called, so that
37 // we can clear out |cur_request_*|. 38 // we can clear out |cur_request_*|.
38 OldCompletionCallback* transient_callback = callback ? &callback_ : NULL; 39 CompletionCallback transient_callback =
40 callback.is_null() ? CompletionCallback() : callback_;
39 41
40 int rv = resolver_->Resolve( 42 int rv = resolver_->Resolve(
41 info, addresses, transient_callback, &request, net_log); 43 info, addresses, transient_callback, &request, net_log);
42 44
43 if (rv == ERR_IO_PENDING) { 45 if (rv == ERR_IO_PENDING) {
44 DCHECK(callback); 46 DCHECK_EQ(false, callback.is_null());
45 // Cleared in OnResolveCompletion(). 47 // Cleared in OnResolveCompletion().
46 cur_request_ = request; 48 cur_request_ = request;
47 cur_request_callback_ = callback; 49 cur_request_callback_ = callback;
48 } 50 }
49 51
50 return rv; 52 return rv;
51 } 53 }
52 54
53 void SingleRequestHostResolver::Cancel() { 55 void SingleRequestHostResolver::Cancel() {
54 if (cur_request_callback_) { 56 if (!cur_request_callback_.is_null()) {
55 resolver_->CancelRequest(cur_request_); 57 resolver_->CancelRequest(cur_request_);
56 cur_request_ = NULL; 58 cur_request_ = NULL;
57 cur_request_callback_ = NULL; 59 cur_request_callback_.Reset();
58 } 60 }
59 } 61 }
60 62
61 void SingleRequestHostResolver::OnResolveCompletion(int result) { 63 void SingleRequestHostResolver::OnResolveCompletion(int result) {
62 DCHECK(cur_request_ && cur_request_callback_); 64 DCHECK(cur_request_);
65 DCHECK_EQ(false, cur_request_callback_.is_null());
63 66
64 OldCompletionCallback* callback = cur_request_callback_; 67 CompletionCallback callback = cur_request_callback_;
65 68
66 // Clear the outstanding request information. 69 // Clear the outstanding request information.
67 cur_request_ = NULL; 70 cur_request_ = NULL;
68 cur_request_callback_ = NULL; 71 cur_request_callback_.Reset();
69 72
70 // Call the user's original callback. 73 // Call the user's original callback.
71 callback->Run(result); 74 callback.Run(result);
72 } 75 }
73 76
74 } // namespace net 77 } // namespace net
OLDNEW
« no previous file with comments | « net/base/single_request_host_resolver.h ('k') | net/base/single_request_host_resolver_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698