net/socket/socks_client_socket_unittest.cc - Issue 8549004: base::Bind: Convert HostResolver::Resolve.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/socks_client_socket_unittest.cc

Issue 8549004: base::Bind: Convert HostResolver::Resolve. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/socks_client_socket_unittest.cc

diff --git a/net/socket/socks_client_socket_unittest.cc b/net/socket/socks_client_socket_unittest.cc

index 2f7645fc9aee666ce2caf6c0dca6dda3fd61bee9..6762e1bb2effefd5d4038b986965a1c7f3f7959a 100644

--- a/net/socket/socks_client_socket_unittest.cc

+++ b/net/socket/socks_client_socket_unittest.cc

@@ -87,11 +87,11 @@ class HangingHostResolverWithCancel : public HostResolver {

virtual int Resolve(const RequestInfo& info,

AddressList* addresses,

- OldCompletionCallback* callback,

+ const CompletionCallback& callback,

RequestHandle* out_req,

const BoundNetLog& net_log) OVERRIDE {

DCHECK(addresses);

- DCHECK(callback);

+ DCHECK_EQ(false, callback.is_null());

EXPECT_FALSE(HasOutstandingRequest());

outstanding_request_ = reinterpret_cast<RequestHandle>(1);

*out_req = outstanding_request_;

« no previous file with comments | « net/socket/socks_client_socket.cc ('k') | net/socket/ssl_client_socket_pool_unittest.cc » ('j') | no next file with comments »