net/proxy/sync_host_resolver_bridge_unittest.cc - Issue 8549004: base::Bind: Convert HostResolver::Resolve.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/sync_host_resolver_bridge_unittest.cc

Issue 8549004: base::Bind: Convert HostResolver::Resolve. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/sync_host_resolver_bridge_unittest.cc

diff --git a/net/proxy/sync_host_resolver_bridge_unittest.cc b/net/proxy/sync_host_resolver_bridge_unittest.cc

index 36586d3281de7c4688e3010452e04887f4e0b986..d8622557e5cbc1004d6a1988286605d81ff6a333 100644

--- a/net/proxy/sync_host_resolver_bridge_unittest.cc

+++ b/net/proxy/sync_host_resolver_bridge_unittest.cc

@@ -32,10 +32,10 @@ class BlockableHostResolver : public HostResolver {

virtual int Resolve(const RequestInfo& info,

AddressList* addresses,

- OldCompletionCallback* callback,

+ const CompletionCallback& callback,

RequestHandle* out_req,

const BoundNetLog& net_log) OVERRIDE {

- EXPECT_TRUE(callback);

+ EXPECT_FALSE(callback.is_null());

EXPECT_TRUE(out_req);

*out_req = reinterpret_cast<RequestHandle*>(1); // Magic value.

« no previous file with comments | « net/proxy/sync_host_resolver_bridge.cc ('k') | net/socket/socks5_client_socket_unittest.cc » ('j') | no next file with comments »