Move GetCharacterFromKeyCode from views::KeyEvent to ui/base/keycodes/keyboard_code_conversion.h.

Move GetCharacterFromKeyCode from views::KeyEvent to ui/base/keycodes/keyboard_code_conversion.h.

BUG=chromium:97261
TEST=try


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110263

[Yusuke Sato, 2011-11-14 10:10:18]

I'd like to move the function to ui:: so that both views::Event and aura::Event
could use it.

[James Su, 2011-11-15 04:00:42]

LGTM.

http://codereview.chromium.org/8511061/diff/2001/ui/base/keycodes/keyboard_co...
File ui/base/keycodes/keyboard_code_conversion.h (right):

http://codereview.chromium.org/8511061/diff/2001/ui/base/keycodes/keyboard_co...
ui/base/keycodes/keyboard_code_conversion.h:35: // to take the actual feature
requirement into account.
Looks like this TODO is not valid anymore. I think we can simply remove it.

[Yusuke Sato, 2011-11-15 05:16:51]

http://codereview.chromium.org/8511061/diff/2001/ui/base/keycodes/keyboard_co...
File ui/base/keycodes/keyboard_code_conversion.h (right):

http://codereview.chromium.org/8511061/diff/2001/ui/base/keycodes/keyboard_co...
ui/base/keycodes/keyboard_code_conversion.h:35: // to take the actual feature
requirement into account.
On 2011/11/15 04:00:42, James Su wrote:
> Looks like this TODO is not valid anymore. I think we can simply remove it.

Done.

[sky, 2011-11-15 16:00:27]

http://codereview.chromium.org/8511061/diff/7002/views/events/event.h
File views/events/event.h (right):

http://codereview.chromium.org/8511061/diff/7002/views/events/event.h#newcode339
views/events/event.h:339: static uint16 GetCharacterFromKeyCode(ui::KeyboardCode
key_code, int flags);
Can we remove this and use the one you're adding to ui/base?

[Yusuke Sato, 2011-11-16 01:14:20]

http://codereview.chromium.org/8511061/diff/7002/views/events/event.h
File views/events/event.h (right):

http://codereview.chromium.org/8511061/diff/7002/views/events/event.h#newcode339
views/events/event.h:339: static uint16 GetCharacterFromKeyCode(ui::KeyboardCode
key_code, int flags);
On 2011/11/15 16:00:27, sky wrote:
> Can we remove this and use the one you're adding to ui/base?

Done.

[sky, 2011-11-16 04:33:33]

LGTM

[commit-bot: I haz the power, 2011-11-16 05:21:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/8511061/13001

[commit-bot: I haz the power, 2011-11-16 06:35:56]

Change committed as 110263