Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: views/events/event_x.cc

Issue 8511061: Move GetCharacterFromKeyCode from views::KeyEvent to ui/base/keycodes/keyboard_code_conversion.h. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review fix Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « views/events/event_win.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "views/events/event.h" 5 #include "views/events/event.h"
6 6
7 #include <gdk/gdk.h> 7 #include <gdk/gdk.h>
8 #include <gdk/gdkx.h> 8 #include <gdk/gdkx.h>
9 #include <X11/extensions/XInput2.h> 9 #include <X11/extensions/XInput2.h>
10 #include <X11/Xlib.h> 10 #include <X11/Xlib.h>
11 11
12 #include "base/logging.h" 12 #include "base/logging.h"
13 #include "base/utf_string_conversions.h" 13 #include "base/utf_string_conversions.h"
14 #include "ui/base/events.h" 14 #include "ui/base/events.h"
15 #include "ui/base/keycodes/keyboard_code_conversion.h"
15 #include "ui/base/keycodes/keyboard_code_conversion_x.h" 16 #include "ui/base/keycodes/keyboard_code_conversion_x.h"
16 #include "ui/base/touch/touch_factory.h" 17 #include "ui/base/touch/touch_factory.h"
17 #include "views/widget/root_view.h" 18 #include "views/widget/root_view.h"
18 19
19 namespace views { 20 namespace views {
20 21
21 namespace { 22 namespace {
22 23
23 // The following two functions are copied from event_gtk.cc. These will be 24 // The following two functions are copied from event_gtk.cc. These will be
24 // removed when GTK dependency is removed. 25 // removed when GTK dependency is removed.
(...skipping 24 matching lines...) Expand all
49 if (!native_event()) { 50 if (!native_event()) {
50 #if defined(TOOLKIT_USES_GTK) 51 #if defined(TOOLKIT_USES_GTK)
51 // This event may have been created from a Gdk event. 52 // This event may have been created from a Gdk event.
52 if (!IsControlDown() && gdk_event()) { 53 if (!IsControlDown() && gdk_event()) {
53 uint16 ch = GetCharacterFromGdkKeyval( 54 uint16 ch = GetCharacterFromGdkKeyval(
54 GetGdkEventKeyFromNative(gdk_event())->keyval); 55 GetGdkEventKeyFromNative(gdk_event())->keyval);
55 if (ch) 56 if (ch)
56 return ch; 57 return ch;
57 } 58 }
58 #endif 59 #endif
59 return GetCharacterFromKeyCode(key_code_, flags()); 60 return ui::GetCharacterFromKeyCode(key_code_, flags());
60 } 61 }
61 62
62 DCHECK(native_event()->type == KeyPress || 63 DCHECK(native_event()->type == KeyPress ||
63 native_event()->type == KeyRelease); 64 native_event()->type == KeyRelease);
64 65
65 uint16 ch = ui::DefaultSymbolFromXEvent(native_event()); 66 uint16 ch = ui::DefaultSymbolFromXEvent(native_event());
66 return ch ? ch : GetCharacterFromKeyCode(key_code_, flags()); 67 return ch ? ch : ui::GetCharacterFromKeyCode(key_code_, flags());
67 } 68 }
68 69
69 uint16 KeyEvent::GetUnmodifiedCharacter() const { 70 uint16 KeyEvent::GetUnmodifiedCharacter() const {
70 if (unmodified_character_) 71 if (unmodified_character_)
71 return unmodified_character_; 72 return unmodified_character_;
72 73
73 if (!native_event()) { 74 if (!native_event()) {
74 #if defined(TOOLKIT_USES_GTK) 75 #if defined(TOOLKIT_USES_GTK)
75 // This event may have been created from a Gdk event. 76 // This event may have been created from a Gdk event.
76 if (gdk_event()) { 77 if (gdk_event()) {
(...skipping 10 matching lines...) Expand all
87 static_cast<GdkModifierType>(key->state & ~kIgnoredModifiers); 88 static_cast<GdkModifierType>(key->state & ~kIgnoredModifiers);
88 guint keyval = 0; 89 guint keyval = 0;
89 if (gdk_keymap_translate_keyboard_state(NULL, key->hardware_keycode, 90 if (gdk_keymap_translate_keyboard_state(NULL, key->hardware_keycode,
90 modifiers, key->group, &keyval, NULL, NULL, NULL)) { 91 modifiers, key->group, &keyval, NULL, NULL, NULL)) {
91 uint16 ch = GetCharacterFromGdkKeyval(keyval); 92 uint16 ch = GetCharacterFromGdkKeyval(keyval);
92 if (ch) 93 if (ch)
93 return ch; 94 return ch;
94 } 95 }
95 } 96 }
96 #endif 97 #endif
97 return GetCharacterFromKeyCode(key_code_, flags() & ui::EF_SHIFT_DOWN); 98 return ui::GetCharacterFromKeyCode(key_code_, flags() & ui::EF_SHIFT_DOWN);
98 } 99 }
99 100
100 DCHECK(native_event()->type == KeyPress || 101 DCHECK(native_event()->type == KeyPress ||
101 native_event()->type == KeyRelease); 102 native_event()->type == KeyRelease);
102 103
103 XKeyEvent *key = &native_event()->xkey; 104 XKeyEvent *key = &native_event()->xkey;
104 105
105 static const unsigned int kIgnoredModifiers = ControlMask | LockMask | 106 static const unsigned int kIgnoredModifiers = ControlMask | LockMask |
106 Mod1Mask | Mod2Mask | Mod3Mask | Mod4Mask | Mod5Mask; 107 Mod1Mask | Mod2Mask | Mod3Mask | Mod4Mask | Mod5Mask;
107 108
108 // We can't use things like (key.state & ShiftMask), as it may mask out bits 109 // We can't use things like (key.state & ShiftMask), as it may mask out bits
109 // used by X11 internally. 110 // used by X11 internally.
110 key->state &= ~kIgnoredModifiers; 111 key->state &= ~kIgnoredModifiers;
111 uint16 ch = ui::DefaultSymbolFromXEvent(native_event()); 112 uint16 ch = ui::DefaultSymbolFromXEvent(native_event());
112 return ch ? ch : 113 return ch ? ch :
113 GetCharacterFromKeyCode(key_code_, flags() & ui::EF_SHIFT_DOWN); 114 ui::GetCharacterFromKeyCode(key_code_, flags() & ui::EF_SHIFT_DOWN);
114 } 115 }
115 116
116 //////////////////////////////////////////////////////////////////////////////// 117 ////////////////////////////////////////////////////////////////////////////////
117 // TouchEvent, public: 118 // TouchEvent, public:
118 119
119 TouchEvent::TouchEvent(const base::NativeEvent& native_event) 120 TouchEvent::TouchEvent(const base::NativeEvent& native_event)
120 : LocatedEvent(native_event), 121 : LocatedEvent(native_event),
121 touch_id_(ui::GetTouchId(native_event)), 122 touch_id_(ui::GetTouchId(native_event)),
122 radius_x_(ui::GetTouchRadiusX(native_event)), 123 radius_x_(ui::GetTouchRadiusX(native_event)),
123 radius_y_(ui::GetTouchRadiusY(native_event)), 124 radius_y_(ui::GetTouchRadiusY(native_event)),
(...skipping 18 matching lines...) Expand all
142 float slot; 143 float slot;
143 if (factory->ExtractTouchParam(*native_event, 144 if (factory->ExtractTouchParam(*native_event,
144 ui::TouchFactory::TP_SLOT_ID, &slot)) { 145 ui::TouchFactory::TP_SLOT_ID, &slot)) {
145 factory->SetSlotUsed(slot, type() == ui::ET_TOUCH_PRESSED); 146 factory->SetSlotUsed(slot, type() == ui::ET_TOUCH_PRESSED);
146 } 147 }
147 } 148 }
148 #endif 149 #endif
149 } 150 }
150 151
151 } // namespace views 152 } // namespace views
OLDNEW
« no previous file with comments | « views/events/event_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698