Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: views/events/event_aura.cc

Issue 8511061: Move GetCharacterFromKeyCode from views::KeyEvent to ui/base/keycodes/keyboard_code_conversion.h. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review fix Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « views/events/event.cc ('k') | views/events/event_wayland.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "views/events/event.h" 5 #include "views/events/event.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "ui/aura/event.h" 8 #include "ui/aura/event.h"
9 #include "ui/base/keycodes/keyboard_code_conversion.h"
9 10
10 namespace views { 11 namespace views {
11 12
12 //////////////////////////////////////////////////////////////////////////////// 13 ////////////////////////////////////////////////////////////////////////////////
13 // LocatedEvent, protected: 14 // LocatedEvent, protected:
14 15
15 LocatedEvent::LocatedEvent(const NativeEvent& native_event) 16 LocatedEvent::LocatedEvent(const NativeEvent& native_event)
16 : Event(native_event, native_event->type(), native_event->flags()), 17 : Event(native_event, native_event->type(), native_event->flags()),
17 location_(static_cast<aura::LocatedEvent*>(native_event)->location()) { 18 location_(static_cast<aura::LocatedEvent*>(native_event)->location()) {
18 } 19 }
19 20
20 //////////////////////////////////////////////////////////////////////////////// 21 ////////////////////////////////////////////////////////////////////////////////
21 // TouchEvent, public: 22 // TouchEvent, public:
22 23
23 TouchEvent::TouchEvent(const NativeEvent& event) 24 TouchEvent::TouchEvent(const NativeEvent& event)
24 : LocatedEvent(event), 25 : LocatedEvent(event),
25 touch_id_(static_cast<aura::TouchEvent*>(event)->touch_id()), 26 touch_id_(static_cast<aura::TouchEvent*>(event)->touch_id()),
26 radius_x_(static_cast<aura::TouchEvent*>(event)->radius_x()), 27 radius_x_(static_cast<aura::TouchEvent*>(event)->radius_x()),
27 radius_y_(static_cast<aura::TouchEvent*>(event)->radius_y()), 28 radius_y_(static_cast<aura::TouchEvent*>(event)->radius_y()),
28 rotation_angle_(static_cast<aura::TouchEvent*>(event)->rotation_angle()), 29 rotation_angle_(static_cast<aura::TouchEvent*>(event)->rotation_angle()),
29 force_(static_cast<aura::TouchEvent*>(event)->force()) { 30 force_(static_cast<aura::TouchEvent*>(event)->force()) {
30 } 31 }
31 32
32 //////////////////////////////////////////////////////////////////////////////// 33 ////////////////////////////////////////////////////////////////////////////////
33 // KeyEvent, public: 34 // KeyEvent, public:
34 35
35 KeyEvent::KeyEvent(const NativeEvent& native_event) 36 KeyEvent::KeyEvent(const NativeEvent& native_event)
36 : Event(native_event, native_event->type(), native_event->flags()), 37 : Event(native_event, native_event->type(), native_event->flags()),
37 key_code_(static_cast<aura::KeyEvent*>(native_event)->key_code()), 38 key_code_(static_cast<aura::KeyEvent*>(native_event)->key_code()),
38 character_(GetCharacterFromKeyCode(key_code_, flags())), 39 character_(ui::GetCharacterFromKeyCode(key_code_, flags())),
39 unmodified_character_(0) { 40 unmodified_character_(0) {
40 } 41 }
41 42
42 uint16 KeyEvent::GetCharacter() const { 43 uint16 KeyEvent::GetCharacter() const {
43 return character_; 44 return character_;
44 } 45 }
45 46
46 uint16 KeyEvent::GetUnmodifiedCharacter() const { 47 uint16 KeyEvent::GetUnmodifiedCharacter() const {
47 if (unmodified_character_) 48 if (unmodified_character_)
48 return unmodified_character_; 49 return unmodified_character_;
49 50
50 return GetCharacterFromKeyCode(key_code_, flags() & ui::EF_SHIFT_DOWN); 51 return ui::GetCharacterFromKeyCode(key_code_, flags() & ui::EF_SHIFT_DOWN);
51 } 52 }
52 53
53 //////////////////////////////////////////////////////////////////////////////// 54 ////////////////////////////////////////////////////////////////////////////////
54 // MouseWheelEvent, public: 55 // MouseWheelEvent, public:
55 56
56 MouseWheelEvent::MouseWheelEvent(const NativeEvent& native_event) 57 MouseWheelEvent::MouseWheelEvent(const NativeEvent& native_event)
57 : MouseEvent(native_event), 58 : MouseEvent(native_event),
58 offset_(ui::GetMouseWheelOffset(native_event->native_event())) { 59 offset_(ui::GetMouseWheelOffset(native_event->native_event())) {
59 } 60 }
60 61
61 } // namespace views 62 } // namespace views
OLDNEW
« no previous file with comments | « views/events/event.cc ('k') | views/events/event_wayland.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698