Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 8506004: Made PropertyType handling even more explicit. (Closed)

Created:
9 years, 1 month ago by Sven Panne
Modified:
9 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Made PropertyType handling even more explicit. Replaced FIRST_PHANTOM_PROPERTY_TYPE by a predicate. Removed the (hopefully) last default cases for switches on PropertyType. Benchmarks show that both changes are performace-neutral. Now every value of PropertyType should either be handled by an explicit case in a switch or by an equality operator. Therefore, the C++ compiler should finally be able to tell us which places to touch when changing PropertyType. Committed: http://code.google.com/p/v8/source/detail?r=9930

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -31 lines) Patch
M src/factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mark-compact.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/profile-generator.cc View 1 chunk +11 lines, -1 line 1 comment Download
M src/property.h View 1 chunk +1 line, -1 line 0 comments Download
M src/property-details.h View 3 chunks +22 lines, -3 lines 0 comments Download
M src/string-stream.cc View 1 chunk +16 lines, -21 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
9 years, 1 month ago (2011-11-09 09:03:23 UTC) #1
Kevin Millikin (Chromium)
9 years, 1 month ago (2011-11-09 12:39:54 UTC) #2
LGTM.

http://codereview.chromium.org/8506004/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

http://codereview.chromium.org/8506004/diff/1/src/profile-generator.cc#newcod...
src/profile-generator.cc:2123: // TODO(svenpanne): Should we really ignore
accessors here?
That's a good question.  They are really a reference to a function or pair of
functions, so we probably should not skip them.  It also looks like they are
counted in the dictionary case.  I'll ping Mikhail about it.

Powered by Google App Engine
This is Rietveld 408576698