Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Side by Side Diff: src/property.h

Issue 8506004: Made PropertyType handling even more explicit. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 bool IsReadOnly() { return details_.IsReadOnly(); } 255 bool IsReadOnly() { return details_.IsReadOnly(); }
256 bool IsDontDelete() { return details_.IsDontDelete(); } 256 bool IsDontDelete() { return details_.IsDontDelete(); }
257 bool IsDontEnum() { return details_.IsDontEnum(); } 257 bool IsDontEnum() { return details_.IsDontEnum(); }
258 bool IsDeleted() { return details_.IsDeleted(); } 258 bool IsDeleted() { return details_.IsDeleted(); }
259 bool IsFound() { return lookup_type_ != NOT_FOUND; } 259 bool IsFound() { return lookup_type_ != NOT_FOUND; }
260 bool IsHandler() { return lookup_type_ == HANDLER_TYPE; } 260 bool IsHandler() { return lookup_type_ == HANDLER_TYPE; }
261 261
262 // Is the result is a property excluding transitions and the null 262 // Is the result is a property excluding transitions and the null
263 // descriptor? 263 // descriptor?
264 bool IsProperty() { 264 bool IsProperty() {
265 return IsFound() && (type() < FIRST_PHANTOM_PROPERTY_TYPE); 265 return IsFound() && GetPropertyDetails().IsProperty();
266 } 266 }
267 267
268 // Is the result a property or a transition? 268 // Is the result a property or a transition?
269 bool IsPropertyOrTransition() { 269 bool IsPropertyOrTransition() {
270 return IsFound() && (type() != NULL_DESCRIPTOR); 270 return IsFound() && (type() != NULL_DESCRIPTOR);
271 } 271 }
272 272
273 bool IsCacheable() { return cacheable_; } 273 bool IsCacheable() { return cacheable_; }
274 void DisallowCaching() { cacheable_ = false; } 274 void DisallowCaching() { cacheable_ = false; }
275 275
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
376 JSReceiver* holder_; 376 JSReceiver* holder_;
377 int number_; 377 int number_;
378 bool cacheable_; 378 bool cacheable_;
379 PropertyDetails details_; 379 PropertyDetails details_;
380 }; 380 };
381 381
382 382
383 } } // namespace v8::internal 383 } } // namespace v8::internal
384 384
385 #endif // V8_PROPERTY_H_ 385 #endif // V8_PROPERTY_H_
OLDNEW
« src/profile-generator.cc ('K') | « src/profile-generator.cc ('k') | src/property-details.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698