Fix gl context change on dropping a texture

Fix gl context change on dropping a texture
As we are now recomputing holes in the draw path, we cannot change the GLContext. This patch resets the change in GL context incurred by DropTexture.


BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108501

[sky, 2011-10-28 22:28:52]

If compositor_gl cares about this, why can't it track the state itself? By that
I mean make TextureGL call back to CompositorGL when it's destroyed, and if
CompositorGL is in the middle of painting it can do this magic.

  -Scott

[pkotwicz, 2011-10-28 22:38:38]

I can do what you suggest if it is ok by you to put back a reference to
CompositorGL inside TextureGL.

[sky, 2011-10-28 22:40:00]

The compositor should outlive the textures. But I know Jonathan has deal with
more issues here than I. He should be able to tell you for sure.

[jonathan.backer, 2011-10-31 18:41:08]

lgtm

[sky, 2011-10-31 20:44:44]

http://codereview.chromium.org/8418035/diff/8001/ui/gfx/compositor/compositor...
File ui/gfx/compositor/compositor_gl.h (right):

http://codereview.chromium.org/8418035/diff/8001/ui/gfx/compositor/compositor...
ui/gfx/compositor/compositor_gl.h:36: scoped_refptr<gfx::ScopedMakeCurrent>
ScopedMakeCurrent() {
Don't inline this.

http://codereview.chromium.org/8418035/diff/8001/ui/gfx/gl/scoped_make_current.h
File ui/gfx/gl/scoped_make_current.h (right):

http://codereview.chromium.org/8418035/diff/8001/ui/gfx/gl/scoped_make_curren...
ui/gfx/gl/scoped_make_current.h:15: class GL_EXPORT ScopedMakeCurrent : public
base::RefCounted<ScopedMakeCurrent> {
Having a RAII object be ref counted breaks the model of how one uses an RAII
object. I would rather either expose the GLContext/GLSurface, or rename
ScopedMakeCurrent to GetScopedMakeCurrent and have it take a pointer to
ScopedMakeCurrent (and change ScopedMakeCurrent to have an empty constructor).

[jonathan.backer, 2011-11-02 23:09:34]

lgtm

http://codereview.chromium.org/8418035/diff/13001/ui/gfx/compositor/composito...
File ui/gfx/compositor/compositor_gl.h (right):

http://codereview.chromium.org/8418035/diff/13001/ui/gfx/compositor/composito...
ui/gfx/compositor/compositor_gl.h:34: virtual bool MakeSharedContextCurrent();
I think that we can deprecate this in favour of the new method below. Maybe file
a bug and address as a separate CL.

[sky, 2011-11-02 23:13:41]

LGTM

[commit-bot: I haz the power, 2011-11-03 16:36:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/8418035/13001

[commit-bot: I haz the power, 2011-11-03 18:11:53]

Change committed as 108501