Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8417016: Remove media::VideoDecodeContext as it has no implementation and is unused. (Closed)

Created:
9 years, 1 month ago by scherkus (not reviewing)
Modified:
9 years, 1 month ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Paweł Hajdan Jr., acolwell+watch_chromium.org, annacc+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org
Visibility:
Public.

Description

Remove media::VideoDecodeContext as it has no implementation and is unused. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107796

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : fix players #

Total comments: 6

Patch Set 4 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -196 lines) Patch
M media/filters/ffmpeg_video_decoder.h View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 1 2 3 2 chunks +3 lines, -6 lines 0 comments Download
M media/filters/ffmpeg_video_decoder_unittest.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M media/media.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M media/tools/player_wtl/movie.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/tools/player_x11/player_x11.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M media/video/ffmpeg_video_decode_engine.h View 1 chunk +1 line, -3 lines 0 comments Download
M media/video/ffmpeg_video_decode_engine.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M media/video/ffmpeg_video_decode_engine_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
D media/video/video_decode_context.h View 1 chunk +0 lines, -84 lines 0 comments Download
M media/video/video_decode_engine.h View 1 2 3 2 chunks +1 line, -13 lines 0 comments Download
D media/video/video_mock_objects.h View 1 chunk +0 lines, -54 lines 0 comments Download
D media/video/video_mock_objects.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M webkit/glue/webmediaplayer_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
scherkus (not reviewing)
yup http://codereview.chromium.org/8417016/diff/1011/media/media.gyp File media/media.gyp (right): http://codereview.chromium.org/8417016/diff/1011/media/media.gyp#newcode239 media/media.gyp:239: 'video/video_decode_engine.h', note: video_decode_context.h was never added
9 years, 1 month ago (2011-10-28 03:51:32 UTC) #1
Ami GONE FROM CHROMIUM
Hawt! http://codereview.chromium.org/8417016/diff/1011/media/video/video_decode_engine.h File media/video/video_decode_engine.h (left): http://codereview.chromium.org/8417016/diff/1011/media/video/video_decode_engine.h#oldcode78 media/video/video_decode_engine.h:78: virtual void Initialize(MessageLoop* message_loop, What is up w/ ...
9 years, 1 month ago (2011-10-28 16:47:31 UTC) #2
scherkus (not reviewing)
http://codereview.chromium.org/8417016/diff/1011/media/video/video_decode_engine.h File media/video/video_decode_engine.h (left): http://codereview.chromium.org/8417016/diff/1011/media/video/video_decode_engine.h#oldcode78 media/video/video_decode_engine.h:78: virtual void Initialize(MessageLoop* message_loop, On 2011/10/28 16:47:31, Ami Fischman ...
9 years, 1 month ago (2011-10-28 17:00:37 UTC) #3
Ami GONE FROM CHROMIUM
9 years, 1 month ago (2011-10-28 17:23:16 UTC) #4 
LGTM++

http://codereview.chromium.org/8417016/diff/1011/media/video/video_decode_eng...
File media/video/video_decode_engine.h (left):

http://codereview.chromium.org/8417016/diff/1011/media/video/video_decode_eng...
media/video/video_decode_engine.h:78: virtual void Initialize(MessageLoop*
message_loop,
On 2011/10/28 17:00:38, scherkus wrote:
> On 2011/10/28 16:47:31, Ami Fischman wrote:
> > What is up w/ dropping message_loop_ from the engine Initialize() method?  
> 
> it's not even used by FFVDE haha

Wow.

Powered by Google App Engine
This is Rietveld 408576698