Make X509Certificate::GetDEREncoded a static function taking an OSCertHandle

Make X509Certificate::GetDEREncoded a static function taking an OSCertHandle

Rather than require an X509Certificate*, which has additional processing
overhead, make X509Certificate::GetDEREncoded a static function which takes an
OSCertHandle. Callers which already have an X509Certificate* can easily use
->os_cert_handle(), while those that have an OSCertHandle, such as by way of
GetIntermediateCertificates(), can use the OSCertHandle directly.

BUG=91464
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108067

[Ryan Sleevi, 2011-10-30 04:27:02]

agl: Since I've been slamming wtc with reviews, would you mind taking this one?
Perfunctory cleanup, nothing exciting to see here (yet).

[agl, 2011-10-30 14:43:20]

LGTM

[wtc, 2011-10-31 19:05:41]

Patch Set 5 LGTM.  Good cleanup, especially replacing clear()+append() with
assign().

Just two comment nits below.

http://codereview.chromium.org/8414047/diff/10001/net/base/x509_certificate.h
File net/base/x509_certificate.h (right):

http://codereview.chromium.org/8414047/diff/10001/net/base/x509_certificate.h...
net/base/x509_certificate.h:343: // This method returns the DER encoded data
from an OSCertHandle.

The |certificate| used in the original comment is
more precise than |data|.

http://codereview.chromium.org/8414047/diff/10001/net/base/x509_certificate.h...
net/base/x509_certificate.h:345: // to |der_encoded|.

We should say something like "On success, returns true and writes the DER
encoded certificate to |*der_encoded|." to emphasize the
meaning of the return value.  It's obvious though.

[commit-bot: I haz the power, 2011-11-01 02:11:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/8414047/13001

[commit-bot: I haz the power, 2011-11-01 03:15:31]

Change committed as 108067