Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1463)

Unified Diff: chrome/browser/net/chrome_fraudulent_certificate_reporter.cc

Issue 8414047: Make X509Certificate::GetDEREncoded a static function taking an OSCertHandle (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase and tweak comment to wtc's verbiage Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/ssl_config_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/chrome_fraudulent_certificate_reporter.cc
diff --git a/chrome/browser/net/chrome_fraudulent_certificate_reporter.cc b/chrome/browser/net/chrome_fraudulent_certificate_reporter.cc
index 9f3fcd1bc5c7816f20626230d476353977ce252b..e71ae581c63f9c943ae135ef9c134c5fbf7ee129 100644
--- a/chrome/browser/net/chrome_fraudulent_certificate_reporter.cc
+++ b/chrome/browser/net/chrome_fraudulent_certificate_reporter.cc
@@ -65,7 +65,8 @@ static std::string BuildReport(
std::string der_encoded, pem_encoded;
net::X509Certificate* certificate = ssl_info.cert;
- if (!certificate->GetDEREncoded(&der_encoded) ||
+ if (!net::X509Certificate::GetDEREncoded(certificate->os_cert_handle(),
+ &der_encoded) ||
!DerToPem(der_encoded, &pem_encoded)) {
LOG(ERROR) << "Could not PEM encode DER certificate";
}
@@ -75,13 +76,9 @@ static std::string BuildReport(
const net::X509Certificate::OSCertHandles& intermediates =
certificate->GetIntermediateCertificates();
-
- for (net::X509Certificate::OSCertHandles::const_iterator
- i = intermediates.begin(); i != intermediates.end(); ++i) {
- scoped_refptr<net::X509Certificate> cert =
- net::X509Certificate::CreateFromHandle(*i, intermediates);
-
- if (!cert->GetDEREncoded(&der_encoded) ||
+ for (size_t i = 0; i < intermediates.size(); ++i) {
+ if (!net::X509Certificate::GetDEREncoded(intermediates[i],
+ &der_encoded) ||
!DerToPem(der_encoded, &pem_encoded)) {
LOG(ERROR) << "Could not PEM encode DER certificate";
continue;
« no previous file with comments | « no previous file | net/base/ssl_config_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698