Make X509Certificate::GetDEREncoded a static function taking an OSCertHandle

net/base/x509_certificate.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_X509_CERTIFICATE_H_
 #define NET_BASE_X509_CERTIFICATE_H_
 #pragma once
 
 #include <string.h>
 
@@ skipping 322 matching lines @@
              int flags,
              CRLSet* crl_set,
              CertVerifyResult* verify_result) const;
 
   // Verifies that |hostname| matches this certificate.
   // Does not verify that the certificate is valid, only that the certificate
   // matches this host.
   // Returns true if it matches.
   bool VerifyNameMatch(const std::string& hostname) const;
 
-  // This method returns the DER encoded certificate.
-  // If the return value is true then the DER encoded certificate is available.
-  // The content of the DER encoded certificate is written to |encoded|.
-  bool GetDEREncoded(std::string* encoded);
+  // This method returns the DER encoded data from an OSCertHandle.

[wtc, 2011/10/31 19:05:41]

The |certificate| used in the original comment is
more precise than |data|.

+  // If the return value is true, then the DER encoded certificate is written
+  // to |der_encoded|.

[wtc, 2011/10/31 19:05:41]

We should say something like "On success, returns true and writes the DER
encoded certificate to |*der_encoded|." to emphasize the
meaning of the return value.  It's obvious though.

+  static bool GetDEREncoded(OSCertHandle cert_handle,
+                            std::string* der_encoded);
 
   OSCertHandle os_cert_handle() const { return cert_handle_; }
 
   // Returns true if two OSCertHandles refer to identical certificates.
   static bool IsSameOSCert(OSCertHandle a, OSCertHandle b);
 
   // Creates an OS certificate handle from the BER-encoded representation.
   // Returns NULL on failure.
   static OSCertHandle CreateOSCertHandleFromBytes(const char* data,
                                                   int length);
@@ skipping 142 matching lines @@
   // (Marked mutable because it's used in a const method.)
   mutable base::Lock verification_lock_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(X509Certificate);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_X509_CERTIFICATE_H_