Split BrowserThread into public API and private implementation, step 1.

Split BrowserThread into public API and private implementation, step 1.

Only content/ now has the ability to create BrowserThread objects,
with the exception that tests can create the
content::TestBrowserThread subclass, and (temporarily) code in chrome/
can create the DeprecatedBrowserThread subclass.

A follow-up change will make content/ take care of its own thread
creation, remove DeprecatedBrowserThread, and move all state and
non-trivial constructors from BrowserThread down to BrowserThreadImpl.

Also moved BrowserProcessSubThread into content/ namespace.  As part
of follow-up cleanup, chrome/ will stop using this class.

BUG=98716
TEST=existing

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107718

[Jói, 2011-10-28 13:43:27]

For the record, the review thread is here:
http://groups.google.com/a/chromium.org/group/chromium-reviews/browse_thread/...

[Timur Iskhodzhanov, 2011-10-29 16:38:55]

PLEASE use Valgrind trybot [or run tests locally] whenever you make such a
massive rename.
And watch the buildbots after commiting.
It'd require just two simple lines of extra patch for you but the
Valgrind/Heapcheck/TSan waterfall was red for 24+ hours, making everyone else's
mistakes unnoticed.

I'd like to note that IMO it is also a responsibility of the reviewer to remind
about Valgrind whenever you do such changes.

It's like pushing a flush button before leaving the restroom - not a big task
for you but makes others' lives much easier.
And I don't like working on Saturdays, you know.

[Jói, 2011-10-30 10:04:55]

Hi Timur,

I'm very sorry you had to work on a Saturday and will definitely heed
your note to use the Valgrind trybot.

In this case, I conceptualized the change as a pure rename and so
didn't think there could be Valgrind/TSan fallout, but actually it
wasn't just a pure rename since the class hierarchy under
BrowserThread was changed.  My apologies.

Cheers,
Jói


On Sat, Oct 29, 2011 at 4:38 PM,  <timurrrr@chromium.org> wrote:
> PLEASE use Valgrind trybot [or run tests locally] whenever you make such a
> massive rename.
> And watch the buildbots after commiting.
> It'd require just two simple lines of extra patch for you but the
> Valgrind/Heapcheck/TSan waterfall was red for 24+ hours, making everyone
> else's
> mistakes unnoticed.
>
> I'd like to note that IMO it is also a responsibility of the reviewer to
> remind
> about Valgrind whenever you do such changes.
>
> It's like pushing a flush button before leaving the restroom - not a big
> task
> for you but makes others' lives much easier.
> And I don't like working on Saturdays, you know.
>
> http://codereview.chromium.org/8392042/
>