chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc - Issue 8392042: Split BrowserThread into public API and private implementation, step 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc

Issue 8392042: Split BrowserThread into public API and private implementation, step 1. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/browser_feature_extractor.cc ('k') | chrome/browser/safe_browsing/client_side_detection_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc

diff --git a/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc b/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc

index cd87e658801f1cccd4e084ea4cb4a0b4f8b7bb83..8e0309ef83b323236e6459ba60441b1fe1ea329a 100644

--- a/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc

+++ b/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc

@@ -12,19 +12,19 @@

#include "base/message_loop.h"

#include "base/stringprintf.h"

#include "base/time.h"

-#include "chrome/common/safe_browsing/csd.pb.h"

#include "chrome/browser/history/history.h"

#include "chrome/browser/history/history_backend.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/safe_browsing/browser_features.h"

#include "chrome/browser/safe_browsing/client_side_detection_service.h"

+#include "chrome/common/safe_browsing/csd.pb.h"

#include "chrome/test/base/chrome_render_view_host_test_harness.h"

#include "chrome/test/base/testing_profile.h"

-#include "content/browser/browser_thread.h"

#include "content/browser/tab_contents/tab_contents.h"

#include "content/browser/tab_contents/test_tab_contents.h"

#include "content/common/view_messages.h"

#include "content/public/common/page_transition_types.h"

+#include "content/test/test_browser_thread.h"

#include "googleurl/src/gurl.h"

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -133,7 +133,7 @@ class BrowserFeatureExtractorTest : public ChromeRenderViewHostTestHarness {

}

- BrowserThread ui_thread_;

+ content::TestBrowserThread ui_thread_;

int num_pending_;

scoped_ptr<BrowserFeatureExtractor> extractor_;

std::map<ClientPhishingRequest*, bool> success_;