Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2975)

Unified Diff: chrome/browser/notifications/desktop_notification_service_unittest.cc

Issue 8392042: Split BrowserThread into public API and private implementation, step 1. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/desktop_notification_service_unittest.cc
diff --git a/chrome/browser/notifications/desktop_notification_service_unittest.cc b/chrome/browser/notifications/desktop_notification_service_unittest.cc
index c60e6270ce676c3950292645530fe267807fbdb3..840be02d657a2889b1224d4ef89fc71e527a5e0f 100644
--- a/chrome/browser/notifications/desktop_notification_service_unittest.cc
+++ b/chrome/browser/notifications/desktop_notification_service_unittest.cc
@@ -12,7 +12,7 @@
#include "chrome/browser/notifications/desktop_notification_service_factory.h"
#include "chrome/test/base/chrome_render_view_host_test_harness.h"
#include "chrome/test/base/testing_profile.h"
-#include "content/browser/browser_thread.h"
+#include "content/test/test_browser_thread.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebNotificationPresenter.h"
@@ -28,10 +28,11 @@ class ThreadProxy : public base::RefCountedThreadSafe<ThreadProxy> {
permission_(WebKit::WebNotificationPresenter::PermissionAllowed) {
// The current message loop was already initalized by the test superclass.
ui_thread_.reset(
- new BrowserThread(BrowserThread::UI, MessageLoop::current()));
+ new content::TestBrowserThread(BrowserThread::UI,
+ MessageLoop::current()));
// Create IO thread, start its message loop.
- io_thread_.reset(new BrowserThread(BrowserThread::IO));
+ io_thread_.reset(new content::TestBrowserThread(BrowserThread::IO));
io_thread_->Start();
// Calling PauseIOThread() here isn't safe, because the runnable method
@@ -85,8 +86,8 @@ class ThreadProxy : public base::RefCountedThreadSafe<ThreadProxy> {
base::WaitableEvent io_event_;
base::WaitableEvent ui_event_;
- scoped_ptr<BrowserThread> ui_thread_;
- scoped_ptr<BrowserThread> io_thread_;
+ scoped_ptr<content::TestBrowserThread> ui_thread_;
+ scoped_ptr<content::TestBrowserThread> io_thread_;
WebKit::WebNotificationPresenter::Permission permission_;
};

Powered by Google App Engine
This is Rietveld 408576698