chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc - Issue 8392042: Split BrowserThread into public API and private implementation, step 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc

Issue 8392042: Split BrowserThread into public API and private implementation, step 1. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/sandboxed_extension_unpacker.cc ('k') | chrome/browser/extensions/speech_input/extension_speech_input_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc

diff --git a/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc b/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc

index f37d06bb05dccaff12edee7c52406cc90c4062d6..05e36ebbee4fc1dea7265b4f3a7ab5a881928327 100644

--- a/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc

+++ b/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc

@@ -14,6 +14,7 @@

#include "chrome/common/extensions/extension.h"

#include "chrome/common/extensions/extension_constants.h"

#include "chrome/common/extensions/extension_unpacker.h"

+#include "content/test/test_browser_thread.h"

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "third_party/skia/include/core/SkBitmap.h"

@@ -59,7 +60,8 @@ class SandboxedExtensionUnpackerTest : public testing::Test {

public:

virtual void SetUp() {

ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());

- file_thread_.reset(new BrowserThread(BrowserThread::FILE, &loop_));

+ file_thread_.reset(new content::TestBrowserThread(BrowserThread::FILE,

+ &loop_));

// It will delete itself.

client_ = new MockSandboxedExtensionUnpackerClient;

client_->DelegateToFake();

@@ -156,7 +158,7 @@ class SandboxedExtensionUnpackerTest : public testing::Test {

scoped_ptr<ExtensionUnpacker> unpacker_;

scoped_refptr<SandboxedExtensionUnpacker> sandboxed_unpacker_;

MessageLoop loop_;

- scoped_ptr<BrowserThread> file_thread_;

+ scoped_ptr<content::TestBrowserThread> file_thread_;

};

TEST_F(SandboxedExtensionUnpackerTest, NoCatalogsSuccess) {