Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 8341128: Defer clearing textures and renderbuffers (Closed)

Created:
9 years, 1 month ago by greggman
Modified:
9 years, 1 month ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Defer clearing textures and renderbuffers Textures and Renderbuffers are now cleared at the last possible moment. This allows them to be cleared only when absolutely necessary. TEST=unit tests BUG=99554 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108226

Patch Set 1 #

Patch Set 2 : fix typos #

Patch Set 3 : fix unit test bug #

Patch Set 4 : fix one more unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2066 lines, -575 lines) Patch
M gpu/command_buffer/service/framebuffer_manager.h View 1 4 chunks +20 lines, -11 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.cc View 1 2 3 8 chunks +95 lines, -29 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager_unittest.cc View 1 2 3 13 chunks +196 lines, -67 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 1 chunk +12 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 44 chunks +276 lines, -92 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 chunk +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 19 chunks +539 lines, -143 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc View 1 4 chunks +9 lines, -15 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 6 chunks +105 lines, -73 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 12 chunks +224 lines, -67 lines 0 comments Download
M gpu/command_buffer/service/renderbuffer_manager.h View 6 chunks +26 lines, -14 lines 0 comments Download
M gpu/command_buffer/service/renderbuffer_manager.cc View 3 chunks +36 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/renderbuffer_manager_unittest.cc View 4 chunks +15 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 14 chunks +65 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 24 chunks +257 lines, -19 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 31 chunks +182 lines, -27 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
greggman
Hey Al, please review. Sorry, it's so big Some notes: Attachment:ValidForAttachemntType needs to be filled ...
9 years, 1 month ago (2011-10-29 03:13:33 UTC) #1
apatrick_chromium
Arg. Well it _looks_ right! LGTM.
9 years, 1 month ago (2011-11-01 18:39:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/8341128/5002
9 years, 1 month ago (2011-11-02 00:07:00 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-02 01:32:21 UTC) #4
Change committed as 108226

Powered by Google App Engine
This is Rietveld 408576698