Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2901)

Unified Diff: gpu/command_buffer/service/renderbuffer_manager_unittest.cc

Issue 8341128: Defer clearing textures and renderbuffers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix one more unit test Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/renderbuffer_manager.cc ('k') | gpu/command_buffer/service/texture_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/renderbuffer_manager_unittest.cc
diff --git a/gpu/command_buffer/service/renderbuffer_manager_unittest.cc b/gpu/command_buffer/service/renderbuffer_manager_unittest.cc
index 954778d196a4a9d5ace5f5c98a4f3e2fe683f688..63719d73c04814fa207f82523a8aa4ebcce57fd0 100644
--- a/gpu/command_buffer/service/renderbuffer_manager_unittest.cc
+++ b/gpu/command_buffer/service/renderbuffer_manager_unittest.cc
@@ -50,12 +50,14 @@ TEST_F(RenderbufferManagerTest, Basic) {
const GLuint kClient2Id = 2;
EXPECT_EQ(kMaxSize, manager_.max_renderbuffer_size());
EXPECT_EQ(kMaxSamples, manager_.max_samples());
+ EXPECT_FALSE(manager_.HaveUnclearedRenderbuffers());
// Check we can create renderbuffer.
manager_.CreateRenderbufferInfo(kClient1Id, kService1Id);
// Check renderbuffer got created.
RenderbufferManager::RenderbufferInfo* info1 =
manager_.GetRenderbufferInfo(kClient1Id);
ASSERT_TRUE(info1 != NULL);
+ EXPECT_FALSE(manager_.HaveUnclearedRenderbuffers());
GLuint client_id = 0;
EXPECT_TRUE(manager_.GetClientId(info1->service_id(), &client_id));
EXPECT_EQ(kClient1Id, client_id);
@@ -66,6 +68,7 @@ TEST_F(RenderbufferManagerTest, Basic) {
// Check we can't get the renderbuffer after we remove it.
manager_.RemoveRenderbufferInfo(kClient1Id);
EXPECT_TRUE(manager_.GetRenderbufferInfo(kClient1Id) == NULL);
+ EXPECT_FALSE(manager_.HaveUnclearedRenderbuffers());
}
TEST_F(RenderbufferManagerTest, Destroy) {
@@ -99,9 +102,6 @@ TEST_F(RenderbufferManagerTest, RenderbufferInfo) {
EXPECT_EQ(static_cast<GLenum>(GL_RGBA4), info1->internal_format());
EXPECT_EQ(0, info1->width());
EXPECT_EQ(0, info1->height());
-
- EXPECT_FALSE(info1->cleared());
- info1->set_cleared();
EXPECT_TRUE(info1->cleared());
// Check if we set the info it gets marked as not cleared.
@@ -109,13 +109,24 @@ TEST_F(RenderbufferManagerTest, RenderbufferInfo) {
const GLenum kFormat = GL_RGBA;
const GLsizei kWidth = 128;
const GLsizei kHeight = 64;
- info1->SetInfo(kSamples, kFormat, kWidth, kHeight);
+ manager_.SetInfo(info1, kSamples, kFormat, kWidth, kHeight);
EXPECT_EQ(kSamples, info1->samples());
EXPECT_EQ(kFormat, info1->internal_format());
EXPECT_EQ(kWidth, info1->width());
EXPECT_EQ(kHeight, info1->height());
EXPECT_FALSE(info1->cleared());
EXPECT_FALSE(info1->IsDeleted());
+ EXPECT_TRUE(manager_.HaveUnclearedRenderbuffers());
+
+ manager_.SetCleared(info1);
+ EXPECT_TRUE(info1->cleared());
+ EXPECT_FALSE(manager_.HaveUnclearedRenderbuffers());
+
+ manager_.SetInfo(info1, kSamples, kFormat, kWidth, kHeight);
+ EXPECT_TRUE(manager_.HaveUnclearedRenderbuffers());
+
+ manager_.RemoveRenderbufferInfo(kClient1Id);
+ EXPECT_FALSE(manager_.HaveUnclearedRenderbuffers());
}
} // namespace gles2
« no previous file with comments | « gpu/command_buffer/service/renderbuffer_manager.cc ('k') | gpu/command_buffer/service/texture_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698