Issue 799008: Make the assumption on the minimum buffer size for GetLogLines explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 799008: Make the assumption on the minimum buffer size for GetLogLines explicit. (Closed)

Created:
10 years, 9 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
antonm

CC:
v8-dev

Visibility:
Public.

Description

Make the assumption on the minimum buffer size for GetLogLines explicit. Committed: http://code.google.com/p/v8/source/detail?r=4097

Patch Set 1 #

Patch Set 2 : Added assert, removed failing checks from test. #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -7 lines)			Patch
M	include/v8.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/log-utils.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/log-utils.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/cctest/test-log.cc	View	2 chunks	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

antonm

LGTM. You might want to add another assert (with slight rework) into Log::GetLogLines in src/log-utils.cc: ...

10 years, 9 months ago (2010-03-11 06:14:45 UTC) #2

mnaganov (inactive)

10 years, 9 months ago (2010-03-11 09:31:48 UTC) #3

On 2010/03/11 06:14:45, antonm wrote:
> LGTM.
> 
> You might want to add another assert (with slight rework) into
Log::GetLogLines
> in src/log-utils.cc:
> 
> ln. 198: ASSERT(end_pos - dest_buf > 1);
> 
> (maybe adding actual_size > 0)
> 
> to check that you never trim the line completely.

Thanks. Added ASSERT(actual_size > 0).

Expand Messages | Collapse Messages