Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Side by Side Diff: include/v8.h

Issue 799008: Make the assumption on the minimum buffer size for GetLogLines explicit. (Closed)
Patch Set: Added assert, removed failing checks from test. Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2007-2009 the V8 project authors. All rights reserved. 1 // Copyright 2007-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2404 matching lines...) Expand 10 before | Expand all | Expand 10 after
2415 * \param from_pos specified a point in a buffer to read from, 0 is the 2415 * \param from_pos specified a point in a buffer to read from, 0 is the
2416 * beginning of a buffer. It is assumed that caller updates its current 2416 * beginning of a buffer. It is assumed that caller updates its current
2417 * position using returned size value from the previous call. 2417 * position using returned size value from the previous call.
2418 * \param dest_buf destination buffer for log data. 2418 * \param dest_buf destination buffer for log data.
2419 * \param max_size size of the destination buffer. 2419 * \param max_size size of the destination buffer.
2420 * \returns actual size of log data copied into buffer. 2420 * \returns actual size of log data copied into buffer.
2421 */ 2421 */
2422 static int GetLogLines(int from_pos, char* dest_buf, int max_size); 2422 static int GetLogLines(int from_pos, char* dest_buf, int max_size);
2423 2423
2424 /** 2424 /**
2425 * The minimum allowed size for a log lines buffer. If the size of
2426 * the buffer given will not be enough to hold a line of the maximum
2427 * length, an attempt to find a log line end in GetLogLines will
2428 * fail, and an empty result will be returned.
2429 */
2430 static const int kMinimumSizeForLogLinesBuffer = 2048;
2431
2432 /**
2425 * Retrieve the V8 thread id of the calling thread. 2433 * Retrieve the V8 thread id of the calling thread.
2426 * 2434 *
2427 * The thread id for a thread should only be retrieved after the V8 2435 * The thread id for a thread should only be retrieved after the V8
2428 * lock has been acquired with a Locker object with that thread. 2436 * lock has been acquired with a Locker object with that thread.
2429 */ 2437 */
2430 static int GetCurrentThreadId(); 2438 static int GetCurrentThreadId();
2431 2439
2432 /** 2440 /**
2433 * Forcefully terminate execution of a JavaScript thread. This can 2441 * Forcefully terminate execution of a JavaScript thread. This can
2434 * be used to terminate long-running scripts. 2442 * be used to terminate long-running scripts.
(...skipping 880 matching lines...) Expand 10 before | Expand all | Expand 10 after
3315 3323
3316 } // namespace v8 3324 } // namespace v8
3317 3325
3318 3326
3319 #undef V8EXPORT 3327 #undef V8EXPORT
3320 #undef V8EXPORT_INLINE 3328 #undef V8EXPORT_INLINE
3321 #undef TYPE_CHECK 3329 #undef TYPE_CHECK
3322 3330
3323 3331
3324 #endif // V8_H_ 3332 #endif // V8_H_
OLDNEW
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698