src/api.cc - Issue 799008: Make the assumption on the minimum buffer size for GetLogLines explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 799008: Make the assumption on the minimum buffer size for GetLogLines explicit. (Closed)

Patch Set: Added assert, removed failing checks from test. Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 93fce79bdfacdf50293e1c30ee5572403187dfc5..af2e7ad243a6952faea1b434c8fc668e60eb836c 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -3580,6 +3580,7 @@ int V8::GetActiveProfilerModules() {

int V8::GetLogLines(int from_pos, char* dest_buf, int max_size) {

#ifdef ENABLE_LOGGING_AND_PROFILING

+ ASSERT(max_size >= kMinimumSizeForLogLinesBuffer);

return i::Logger::GetLogLines(from_pos, dest_buf, max_size);

#endif

return 0;

« no previous file with comments | « include/v8.h ('k') | src/log-utils.h » ('j') | no next file with comments »