src/log-utils.h - Issue 799008: Make the assumption on the minimum buffer size for GetLogLines explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/log-utils.h

Issue 799008: Make the assumption on the minimum buffer size for GetLogLines explicit. (Closed)

Patch Set: Added assert, removed failing checks from test. Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/log-utils.h

diff --git a/src/log-utils.h b/src/log-utils.h

index b769e9046f21d12b0ec49a040fd63253350e8811..8889f1b77a30b17f9e7ae3802a2ffeeb350c71e9 100644

--- a/src/log-utils.h

+++ b/src/log-utils.h

@@ -115,7 +115,7 @@ class Log : public AllStatic {

}

// Size of buffer used for formatting log messages.

- static const int kMessageBufferSize = 2048;

+ static const int kMessageBufferSize = v8::V8::kMinimumSizeForLogLinesBuffer;

private:

typedef int (*WritePtr)(const char* msg, int length);

« no previous file with comments | « src/api.cc ('k') | src/log-utils.cc » ('j') | no next file with comments »