Relanding precompiled header support for VS 2008, now enabled for

Relanding precompiled header support for VS 2008, now enabled for
Debug builds only as official builds were failing with out of memory
errors.

This is mostly a revert of http://crrev.com/101836 which was a
revert of the original change, http://crrev.com/101474, except for a
modification to build/win_precompile.gypi to only enable use of
precompiled headers in the Debug configuration.

BUG=none
TEST=it builds

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102029

[Jói, 2011-09-20 11:42:21]

Jean-Luc: Please review the changed file, build/win_precompile.gypi

Brett: FYI only. Will commit TBR based on your previous LGTM if I don't hear
from you, as base/time_win.cc has not changed.

Cheers,
Jói

[Jói, 2011-09-20 12:27:02]

Jean-Luc, please note the try servers showed that I needed to also change the
mini_installer.gyp file to turn off precompiled headers in a way that matches
how they are turned on.  So there are changes to both .gyp(i) files.

Cheers,
Jói

[jeanluc1, 2011-09-20 16:54:25]

lgtm

http://codereview.chromium.org/7977003/diff/3001/build/win_precompile.gypi
File build/win_precompile.gypi (right):

http://codereview.chromium.org/7977003/diff/3001/build/win_precompile.gypi#ne...
build/win_precompile.gypi:26: # the precompiled header file in all source
files).
That's one heck of a long sentence that's hard to parse. Perhaps something like:

Sources can't be specified inside the 'Debug' configuration.   Since
precompile.cc only contains comments, it won't have any effect for 'Release'
builds.  The usage of precompiled headers is triggered only by the
'msvs_precompiled_header', found in the 'Debug' configuration above.

http://codereview.chromium.org/7977003/diff/3001/chrome/installer/mini_instal...
File chrome/installer/mini_installer.gyp (right):

http://codereview.chromium.org/7977003/diff/3001/chrome/installer/mini_instal...
chrome/installer/mini_installer.gyp:226: 
Extra line on purpose?

[brettw, 2011-09-20 20:47:41]

LGTM again

[Jói, 2011-09-20 21:44:06]

Thanks, committing in a bit.

http://codereview.chromium.org/7977003/diff/3001/build/win_precompile.gypi
File build/win_precompile.gypi (right):

http://codereview.chromium.org/7977003/diff/3001/build/win_precompile.gypi#ne...
build/win_precompile.gypi:26: # the precompiled header file in all source
files).
On 2011/09/20 16:54:25, jeanluc1 wrote:
> That's one heck of a long sentence that's hard to parse. Perhaps something
like:
> 
> Sources can't be specified inside the 'Debug' configuration.   Since
> precompile.cc only contains comments, it won't have any effect for 'Release'
> builds.  The usage of precompiled headers is triggered only by the
> 'msvs_precompiled_header', found in the 'Debug' configuration above.

Switched to just the following:

  # Sources can't be specified inside the 'Debug'
  # configuration. Since precompile.cc only contains
  # comments, it won't have any effect for 'Release' builds.

http://codereview.chromium.org/7977003/diff/3001/chrome/installer/mini_instal...
File chrome/installer/mini_installer.gyp (right):

http://codereview.chromium.org/7977003/diff/3001/chrome/installer/mini_instal...
chrome/installer/mini_installer.gyp:226: 
On 2011/09/20 16:54:25, jeanluc1 wrote:
> Extra line on purpose?

No, fixed.

[jeanluc1, 2011-09-20 21:49:37]

lgtm